looked for places where Countdown monograms/uris were being constructed by hand, and updated with modern versions
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12524: Modernize Countdown
- Commits
- rPc6c25b055b36: Cleanup Countdown manual construction of monograms/uris
clicked around the Countdown UI, looking for broken links
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php | ||
|---|---|---|
| 39 | Is there a better way to do this? I also couldn't figure out how to test this. | |
| src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php | ||
|---|---|---|
| 39 | You can pht('%s: %s', $countdown->getMonogram(), $name). Not sure that's actually better but maybe looks a little cleaner. | |
Comment Actions
It's currently unclear whether pht('%s: %s', ..., ...) will be helpful (since, say, Chinese users would rather have 🐳 as a separator than :) or harmful (since, say, no one wants to translate or can figure out what it's supposed to mean) when we actually internationalize.