Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15383643
D17665.id42487.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D17665.id42487.diff
View Options
diff --git a/src/applications/countdown/controller/PhabricatorCountdownViewController.php b/src/applications/countdown/controller/PhabricatorCountdownViewController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownViewController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownViewController.php
@@ -28,7 +28,7 @@
$crumbs = $this
->buildApplicationCrumbs()
- ->addTextCrumb("C{$id}")
+ ->addTextCrumb($countdown->getMonogram())
->setBorder(true);
$epoch = $countdown->getEpoch();
diff --git a/src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php b/src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
--- a/src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
+++ b/src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
@@ -35,9 +35,9 @@
$name = $countdown->getTitle();
$id = $countdown->getID();
- $handle->setName("C{$id}");
- $handle->setFullName("C{$id}: {$name}");
- $handle->setURI("/countdown/{$id}/");
+ $handle->setName($countdown->getMonogram());
+ $handle->setFullName(pht('%s: %s', $countdown->getMonogram(), $name));
+ $handle->setURI($countdown->getURI());
}
}
diff --git a/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php b/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php
--- a/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php
+++ b/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php
@@ -108,7 +108,7 @@
$item = id(new PHUIObjectItemView())
->setUser($viewer)
->setObject($countdown)
- ->setObjectName("C{$id}")
+ ->setObjectName($countdown->getMonogram())
->setHeader($countdown->getTitle())
->setHref($this->getApplicationURI("{$id}/"))
->addByline(
diff --git a/src/applications/countdown/view/PhabricatorCountdownView.php b/src/applications/countdown/view/PhabricatorCountdownView.php
--- a/src/applications/countdown/view/PhabricatorCountdownView.php
+++ b/src/applications/countdown/view/PhabricatorCountdownView.php
@@ -14,12 +14,12 @@
require_celerity_resource('phabricator-countdown-css');
$header_text = array(
- 'C'.$countdown->getID(),
+ $countdown->getMonogram(),
' ',
phutil_tag(
'a',
array(
- 'href' => '/countdown/'.$countdown->getID(),
+ 'href' => $countdown->getURI(),
),
$countdown->getTitle()),
);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 15, 5:27 PM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7383843
Default Alt Text
D17665.id42487.diff (2 KB)
Attached To
Mode
D17665: Cleanup Countdown manual construction of monograms/uris
Attached
Detach File
Event Timeline
Log In to Comment