Page MenuHomePhabricator
Differential D17641

Write a "Developer Setup" guide for onboarding
ClosedPublic
Actions

Authored by epriestley on Apr 9 2017, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 9:26 AM
Unknown Object (File)
Sat, Apr 6, 12:14 AM
Unknown Object (File)
Fri, Apr 5, 11:34 AM
Unknown Object (File)
Fri, Apr 5, 10:46 AM
Unknown Object (File)
Fri, Apr 5, 10:38 AM
Unknown Object (File)
Fri, Apr 5, 8:37 AM
Unknown Object (File)
Fri, Apr 5, 6:50 AM
Unknown Object (File)
Fri, Apr 5, 6:35 AM
View All Files
Subscribers
cspeckmim
Tokens
"Like" token, awarded by cspeckmim.

Details

Reviewers
amckinley
chad
Maniphest Tasks
T11561: Write a "Contributor Onboarding" document
Commits
rPc9f51fd40523: Write a "Developer Setup" guide for onboarding
Summary

Fixes T11561. Collect guidance about local configuration which hasn't been obvious in the past.

Test Plan
  • Read document carefully.
  • Used ./bin/diviner generate to generate documentation.
  • Previewed in Diviner locally:

Screen Shot 2017-04-09 at 4.57.46 AM.png (1×2 px, 297 KB)

Diff Detail

Repository
rP Phabricator
Branch
contrib1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16363
Build 21764: Run Core Tests
Build 21763: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 9 2017, 11:58 AM
Harbormaster completed remote builds in B16356: Diff 42427.Apr 9 2017, 11:59 AM
epriestley mentioned this in T12525: amckinley's Onboarding.Apr 9 2017, 1:46 PM
cspeckmim added a subscriber: cspeckmim.Apr 9 2017, 2:43 PM
cspeckmim added inline comments.
src/docs/contributor/developer_setup.diviner
55–56

Maybe it's obvious, but needing to restart the web service after modifying is typically necessary too.

cspeckmim awarded a token.Apr 9 2017, 2:43 PM
epriestley added a comment.Apr 9 2017, 2:48 PM

Maybe it's obvious, but needing to restart the web service after modifying is typically necessary too.

It shouldn't be if you enable phabricator.developer-mode, then resolve any setup warnings. They should tune apc.stat and/or opcache.validate_timestamps/opcache.revalidate_freq appropriately for development (never require a restart) or production (improve performance).

cspeckmim added a comment.Apr 9 2017, 3:45 PM

Aha! That will simplify my dev setup/process

chad accepted this revision.Apr 9 2017, 5:50 PM
This revision is now accepted and ready to land.Apr 9 2017, 5:50 PM
chad added a comment.Apr 9 2017, 6:59 PM

Maybe something about lipsum

epriestley added a comment.Apr 9 2017, 7:01 PM

Oh, good thought.

epriestley updated this revision to Diff 42434.Apr 10 2017, 3:32 PM
  • Add notes about bin/lipsum.
Harbormaster completed remote builds in B16363: Diff 42434.Apr 10 2017, 3:33 PM
Closed by commit rPc9f51fd40523: Write a "Developer Setup" guide for onboarding (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2017, 3:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
docs/
contributor/
112 lines

Diff 42434

View Options

src/docs/contributor/developer_setup.diviner

Loading...
Phabricator · Built by Phacility