Page MenuHomePhabricator

Remove extra parameter in newStandardEditField() call
ClosedPublic

Authored by epriestley on Feb 16 2017, 3:02 PM.
Tags
None
Referenced Files
F15448929: D17370.id41770.diff
Fri, Mar 28, 7:43 AM
F15448412: D17370.id41768.diff
Fri, Mar 28, 4:41 AM
F15446140: D17370.id.diff
Thu, Mar 27, 5:23 PM
F15441986: D17370.diff
Wed, Mar 26, 8:53 PM
F15438426: D17370.id41768.diff
Wed, Mar 26, 12:36 AM
F15437129: D17370.diff
Tue, Mar 25, 5:45 PM
F15377069: D17370.id.diff
Thu, Mar 13, 7:46 AM
Unknown Object (File)
Mar 3 2025, 12:26 PM
Subscribers
None

Details

Summary

See D14617. This could probably go either way but we don't currently need $engine in newStandardEditField(), so just get rid of it.

Test Plan

Edited a task with standard custom fields defined.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/infrastructure/customfield/field/PhabricatorCustomField.php
1097

Perhaps remove the parameter too, it's now unused.

I think subclasses might reasonably want to override this method and need access to $engine to do so. This is theoretical in the upstream, but PhabricatorCustomField is extensible by third-party code, and we have some (non-custom) fields in first-party applications where behavior depends on $editor (for example, fields which only appear on either the "create" or "edit" screen, but not both).

This revision is now accepted and ready to land.Feb 16 2017, 4:50 PM
This revision was automatically updated to reflect the committed changes.