Remove extra parameter in newStandardEditField() call
ClosedPublic

Authored by epriestley on Thu, Feb 16, 3:02 PM.

Details

Summary

See D14617. This could probably go either way but we don't currently need $engine in newStandardEditField(), so just get rid of it.

Test Plan

Edited a task with standard custom fields defined.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Thu, Feb 16, 3:02 PM
vrana added inline comments.Thu, Feb 16, 3:15 PM
src/infrastructure/customfield/field/PhabricatorCustomField.php
1097

Perhaps remove the parameter too, it's now unused.

I think subclasses might reasonably want to override this method and need access to $engine to do so. This is theoretical in the upstream, but PhabricatorCustomField is extensible by third-party code, and we have some (non-custom) fields in first-party applications where behavior depends on $editor (for example, fields which only appear on either the "create" or "edit" screen, but not both).

vrana accepted this revision.Thu, Feb 16, 4:50 PM
This revision is now accepted and ready to land.Thu, Feb 16, 4:50 PM
This revision was automatically updated to reflect the committed changes.