Page MenuHomePhabricator
Differential D17348

Make Panels slightly easier to find and use
ClosedPublic
Actions

Authored by chad on Feb 14 2017, 12:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 4:41 AM
Unknown Object (File)
Thu, Apr 25, 1:33 AM
Unknown Object (File)
Tue, Apr 23, 9:09 PM
Unknown Object (File)
Tue, Apr 23, 9:09 PM
Unknown Object (File)
Tue, Apr 23, 9:09 PM
Unknown Object (File)
Tue, Apr 23, 9:09 PM
Unknown Object (File)
Thu, Apr 11, 9:07 AM
Unknown Object (File)
Tue, Apr 9, 5:44 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10390: Dashboards v2 (UX)
Commits
rP2c09fc56051b: Make Panels slightly easier to find and use
Summary

Ref T10390, turns "add existing panel" into a typeahead, and add lots more information to search.

Test Plan

Add an existing panel, click the search icon, see more information (type, engine).

Diff Detail

Repository
rP Phabricator
Branch
panel-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15619
Build 20613: Run Core Tests
Build 20612: arc lint + arc unit

Event Timeline

chad created this revision.Feb 14 2017, 12:33 AM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 14 2017, 12:33 AM
chad added inline comments.Feb 14 2017, 12:34 AM
src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
14

oooh

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
14

ahhh

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php
14

zomg

Harbormaster completed remote builds in B15619: Diff 41721.Feb 14 2017, 12:34 AM
chad added inline comments.Feb 14 2017, 12:34 AM
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

feels janky.

epriestley accepted this revision.Feb 14 2017, 2:37 AM
epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

This is the best available way to do it, but I agree it feels a little janky.

This revision is now accepted and ready to land.Feb 14 2017, 2:37 AM
Closed by commit rP2c09fc56051b: Make Panels slightly easier to find and use (authored by chad, committed by chad). · Explain WhyFeb 14 2017, 3:38 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D18121: Allow dashboard panels to be found by monogram.Jun 13 2017, 9:47 PM

Revision Contents
Changeset List

Diff 41721

View Options

src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php

Loading...
View Options

src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php

Loading...
Phabricator · Built by Phacility