Page MenuHomePhabricator

Make Panels slightly easier to find and use
ClosedPublic

Authored by chad on Feb 14 2017, 12:33 AM.
Tags
None
Referenced Files
F12857292: D17348.id41726.diff
Fri, Mar 29, 10:24 AM
Unknown Object (File)
Sun, Mar 10, 9:07 AM
Unknown Object (File)
Jan 27 2024, 1:12 AM
Unknown Object (File)
Jan 27 2024, 1:02 AM
Unknown Object (File)
Jan 25 2024, 10:47 AM
Unknown Object (File)
Dec 27 2023, 9:49 AM
Unknown Object (File)
Dec 21 2023, 4:22 PM
Unknown Object (File)
Dec 21 2023, 12:18 AM
Subscribers

Details

Summary

Ref T10390, turns "add existing panel" into a typeahead, and add lots more information to search.

Test Plan

Add an existing panel, click the search icon, see more information (type, engine).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php
14

oooh

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
14

ahhh

src/applications/dashboard/paneltype/PhabricatorDashboardTextPanelType.php
14

zomg

src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

feels janky.

epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
26

This is the best available way to do it, but I agree it feels a little janky.

This revision is now accepted and ready to land.Feb 14 2017, 2:37 AM
This revision was automatically updated to reflect the committed changes.