Just add the monogram to the datasource's name field
so that it will match when typing Wnn in the typeahead field.
Details
Details
- Reviewers
chad epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPe1850b3c4e4e: Allow dashboard panels to be found by monogram
Tested locally on my dev phab. Try searching for a panel
by monogram in the 'Add existing panel' dialog on the
'arrange workboard' interface.
Previously: typing W123 showed no results.
After this change: typing W123 finds the panel W123
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This seems like it was probably just an oversight and it's a trivial change so I'm upstreaming. Already in queue to be deployed downstream in Wikimedia's install.
Comment Actions
I think you can just remove setDisplayName(), it should default to the name if not explicitly provided.
Comment Actions
And, yeah, I can't think of any reason we'd want the behavior as written before this change. It looks like it came from D17348 but I imagine the intent was just this change, not "show the monogram but don't let users select with it".
Comment Actions
Indeed, I tested this and removing the setDisplayName retains the correct behavior (show the monogram AND let you search by monogram)