Restore "Auditor" as an alias for the commit message field "Auditors"
ClosedPublic
Actions

Authored by epriestley on Feb 3 2017, 2:18 PM.

Details

Reviewers

chad

Maniphest Tasks

T12197: Audits are no longer triggered using singular "Auditor:"

Commits

rPfd0591e16880: Restore "Auditor" as an alias for the commit message field "Auditors"

Summary

Fixes T12197. I think this field was never recognized by Differential (it doesn't appear in D17070, but maybe that isn't the right change).

It was recognized by the ad-hoc regular expression which I replaced with a formal parser in D17262.

Allow the former parser to accept "Auditor" as an alias for "Auditors".

Test Plan

Committed a change with Auditor: dog, saw the audit trigger correctly in the web UI.

Diff Detail

Repository

rP Phabricator

Branch

auditor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15515
Build 20458: Run Core Tests
Build 20457: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 3 2017, 2:18 PM

Harbormaster completed remote builds in B15515: Diff 41618.Feb 3 2017, 2:19 PM

epriestley mentioned this in T12197: Audits are no longer triggered using singular "Auditor:".Feb 3 2017, 2:31 PM

chad accepted this revision.Feb 3 2017, 4:48 PM

This revision is now accepted and ready to land.Feb 3 2017, 4:48 PM

Closed by commit rPfd0591e16880: Restore "Auditor" as an alias for the commit message field "Auditors" (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2017, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

field/

DifferentialAuditorsCommitMessageField.php

6 lines

Diff 41618

View Options

src/applications/differential/field/DifferentialAuditorsCommitMessageField.php

Restore "Auditor" as an alias for the commit message field "Auditors"ClosedPublicActions