Page MenuHomePhabricator
Differential D17070

Simplify Auditors custom field in Differential
ClosedPublic
Actions

Authored by epriestley on Dec 16 2016, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 6:15 PM
Unknown Object (File)
Mon, Dec 16, 5:54 PM
Unknown Object (File)
Tue, Dec 10, 8:17 PM
Unknown Object (File)
Sun, Dec 8, 11:24 AM
Unknown Object (File)
Sat, Dec 7, 11:07 AM
Unknown Object (File)
Tue, Dec 3, 10:43 AM
Unknown Object (File)
Mon, Dec 2, 8:05 PM
Unknown Object (File)
Nov 19 2024, 7:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP914d9fa8b94f: Simplify Auditors custom field in Differential
Summary

Ref T11114. This field just stores the value of "Auditors" so you can trigger auditors explicitly later on if you want.

Test Plan

Created and edited revisions with "Auditors".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 41058.Dec 16 2016, 2:49 PM
epriestley updated this revision to Diff 41059.
epriestley retitled this revision from to Simplify Auditors custom field in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11114: Move Differential to EditEngine.
  • Not a template field.
epriestley updated this revision to Diff 41063.Dec 16 2016, 3:06 PM
  • Slightly cleaner (?) patch, allow custom fields to be Conduit-only.
chad accepted this revision.Dec 16 2016, 3:29 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:29 PM
Closed by commit rP914d9fa8b94f: Simplify Auditors custom field in Differential (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D17306: Restore "Auditor" as an alias for the commit message field "Auditors".Feb 3 2017, 2:18 PM
epriestley mentioned this in rPfd0591e16880: Restore "Auditor" as an alias for the commit message field "Auditors".Feb 3 2017, 5:14 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
31 lines
field/
8 lines
2 lines
infrastructure/
customfield/
editor/
4 lines
engineextension/
2 lines
field/
21 lines

Diff 41086

View Options

src/applications/differential/customfield/DifferentialAuditorsField.php

Loading...
View Options

src/applications/differential/field/DifferentialAuditorsCommitMessageField.php

Loading...
View Options

src/applications/differential/field/DifferentialCommitMessageField.php

Loading...
View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldEditEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility