Page MenuHomePhabricator

Restore "Auditor" as an alias for the commit message field "Auditors"
ClosedPublic

Authored by epriestley on Feb 3 2017, 2:18 PM.
Tags
None
Referenced Files
F15447628: D17306.id41621.diff
Fri, Mar 28, 12:43 AM
F15447627: D17306.id41618.diff
Fri, Mar 28, 12:43 AM
F15447626: D17306.id.diff
Fri, Mar 28, 12:43 AM
F15442600: D17306.diff
Wed, Mar 26, 11:49 PM
F15434079: D17306.id41621.diff
Tue, Mar 25, 1:53 AM
F15421356: D17306.id41618.diff
Fri, Mar 21, 10:55 PM
F15420392: D17306.id.diff
Fri, Mar 21, 1:41 PM
F15412097: D17306.diff
Wed, Mar 19, 11:17 AM
Subscribers
None

Details

Summary

Fixes T12197. I think this field was never recognized by Differential (it doesn't appear in D17070, but maybe that isn't the right change).

It was recognized by the ad-hoc regular expression which I replaced with a formal parser in D17262.

Allow the former parser to accept "Auditor" as an alias for "Auditors".

Test Plan

Committed a change with Auditor: dog, saw the audit trigger correctly in the web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable