Remove menu item pinning from Home and Favorites profile menus
ClosedPublic

Authored by epriestley on Feb 2 2017, 3:40 PM.

Details

Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Feb 2 2017, 3:40 PM
chad accepted this revision.Feb 2 2017, 4:41 PM
This revision is now accepted and ready to land.Feb 2 2017, 4:41 PM
This revision was automatically updated to reflect the committed changes.