Page MenuHomePhabricator

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic

Authored by epriestley on Feb 2 2017, 3:40 PM.
Tags
None
Referenced Files
F19244494: D17298.diff
Mon, Dec 22, 1:01 AM
F19057387: D17298.id.diff
Nov 28 2025, 10:25 PM
F19048548: D17298.diff
Nov 27 2025, 2:57 PM
F18947962: D17298.id41605.diff
Nov 11 2025, 10:40 PM
F18947220: D17298.id41617.diff
Nov 11 2025, 9:34 PM
F18946439: D17298.diff
Nov 11 2025, 8:16 PM
F18818238: D17298.id.diff
Oct 21 2025, 10:26 PM
F18809726: D17298.id41605.diff
Oct 19 2025, 4:24 PM
Subscribers
None

Details

Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable