Page MenuHomePhabricator
Differential D17298

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic
Actions

Authored by epriestley on Feb 2 2017, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 12:39 PM
Unknown Object (File)
Mon, Nov 18, 9:22 AM
Unknown Object (File)
Wed, Nov 13, 10:23 PM
Unknown Object (File)
Tue, Nov 5, 3:32 AM
Unknown Object (File)
Oct 19 2024, 4:49 PM
Unknown Object (File)
Oct 19 2024, 12:07 PM
Unknown Object (File)
Oct 19 2024, 12:34 AM
Unknown Object (File)
Oct 15 2024, 5:07 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12174: Home Menu Errata
Commits
rPd182d7eaf1d1: Remove menu item pinning from Home and Favorites profile menus
Summary

Ref T12174.

  • Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
  • Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.
Test Plan
  • Saw no pinning UI on Home/Favorites.
  • Added a personal dashboard on Home, it automatically became the new default.
  • Pinned stuff normally on Projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
search/
engine/
43 lines

Diff 41617

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
Phabricator · Built by Phacility