Page MenuHomePhabricator

Make implicit audits by the Owners tool use modern code
ClosedPublic

Authored by epriestley on Jan 30 2017, 8:22 PM.
Tags
None
Referenced Files
F13060654: D17266.diff
Fri, Apr 19, 6:11 PM
Unknown Object (File)
Thu, Apr 11, 10:13 AM
Unknown Object (File)
Mon, Apr 8, 11:10 PM
Unknown Object (File)
Mon, Apr 8, 5:39 AM
Unknown Object (File)
Tue, Apr 2, 11:35 PM
Unknown Object (File)
Sat, Mar 30, 4:42 PM
Unknown Object (File)
Sat, Mar 30, 4:42 PM
Unknown Object (File)
Fri, Mar 29, 6:14 PM
Subscribers
None

Details

Summary

Ref T10978. This updates audits triggered by Owners to use a modern transaction. Minor changes:

  • After D17264, we no longer need the "AUDIT_NOT_REQUIRED" fake-audits to record package membership. This no longer creates them.
  • This previously saved English-language, untranslatable text strings about audit details onto the audit relationship. I've removed them, per discussion in D17263.

The "Audit Reasons" here are potentially a little more useful than the Herald/Explicit-By-Owner ones were, since the rules are a little more complex, but I'd still like to see evidence that we need them.

In particular, the transaction record now says "Owners added auditors: ...", just like Differential, so the source of the auditors should be clear:

Screen Shot 2017-01-30 at 12.09.18 PM.png (120×439 px, 14 KB)

T11118 (roughly "add several Owners audit modes", despite the title at time of writing) might impact this too. Basically, this is simple and maybe good enough; if it's not quite good enough we can refine it.

Test Plan

Ran bin/repository reparse --owners <commit> saw appropriate owners audits trigger.

Diff Detail

Repository
rP Phabricator
Branch
audit10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15414
Build 20311: Run Core Tests
Build 20310: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 30 2017, 10:24 PM
This revision was automatically updated to reflect the committed changes.