Page MenuHomePhabricator

Use DifferentialCommitMessageParser and Modular Transactions to implement "Auditors: ..."
ClosedPublic

Authored by epriestley on Jan 30 2017, 5:53 PM.
Tags
None
Referenced Files
F13092845: D17262.diff
Thu, Apr 25, 5:50 AM
F13084132: D17262.diff
Wed, Apr 24, 10:48 PM
Unknown Object (File)
Sun, Apr 21, 6:52 PM
Unknown Object (File)
Fri, Apr 19, 6:10 PM
Unknown Object (File)
Wed, Apr 17, 2:14 PM
Unknown Object (File)
Mon, Apr 1, 1:38 AM
Unknown Object (File)
Sat, Mar 30, 4:41 PM
Unknown Object (File)
Sat, Mar 30, 4:41 PM
Subscribers
None

Details

Summary

Ref T10978. Updates how we implement "Auditors: ..." in commit messages:

  • Use the same parsing code as everything else.
    • (Also: parse package names.)
  • Use the new transaction code.

Also, fix some UI strings.

Test Plan

Used bin/repository reparse --herald <commit> to re-run this code on commits with various messages (valid Auditors, invalid Auditors, no Auditors). Saw appropriate auditors added in the UI.

Diff Detail

Repository
rP Phabricator
Branch
audit7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15409
Build 20302: Run Core Tests
Build 20301: arc lint + arc unit