Paths

Table of Contentst

Differential D17254

Remove "diffusion.createcomment" Conduit API method
ClosedPublic
Actions

Authored by epriestley on Jan 26 2017, 6:27 PM.

Tags

None

Referenced Files

	F14495546: D17254.diff
	Fri, Jan 3, 9:02 AM

	F14492430: D17254.id.diff
	Thu, Jan 2, 7:32 PM

	Unknown Object (File)
	Wed, Jan 1, 8:22 PM

	Unknown Object (File)
	Fri, Dec 13, 8:56 AM

	Unknown Object (File)
	Fri, Dec 6, 7:44 AM

	Unknown Object (File)
	Thu, Dec 5, 7:48 PM

	Unknown Object (File)
	Thu, Dec 5, 5:00 PM

	Unknown Object (File)
	Nov 29 2024, 12:42 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10978: Modernize Audit

Commits

rP2e3e078358c1: Remove "diffusion.createcomment" Conduit API method

Summary

Ref T10978. This was introduced in D6923 in 2013 as a deprecated method (before methods were extensible) and has only ever been deprecated. It no longer works after D17250 (despite my mistaken claim there that we never had an API for actions), and has been superceded by diffusion.commit.edit which is a modern, fully-power method.

Test Plan

Viewed Conduit console, no longer saw method.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 26 2017, 6:27 PM

Harbormaster completed remote builds in B15387: Diff 41505.Jan 26 2017, 6:28 PM

chad accepted this revision.Jan 26 2017, 8:25 PM

This revision is now accepted and ready to land.Jan 26 2017, 8:25 PM

Closed by commit rP2e3e078358c1: Remove "diffusion.createcomment" Conduit API method (authored by epriestley, committed by epriestley). · Explain WhyJan 26 2017, 8:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

conduit/

DiffusionCreateCommentConduitAPIMethod.php

Diff 41508

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php

Loading...