Page MenuHomePhabricator

Remove "diffusion.createcomment" Conduit API method
ClosedPublic

Authored by epriestley on Jan 26 2017, 6:27 PM.
Tags
None
Referenced Files
F13180317: D17254.diff
Wed, May 8, 11:11 PM
F13177829: D17254.diff
Wed, May 8, 7:59 PM
Unknown Object (File)
Sun, May 5, 1:14 AM
Unknown Object (File)
Thu, May 2, 6:12 PM
Unknown Object (File)
Mon, Apr 29, 5:17 AM
Unknown Object (File)
Thu, Apr 25, 12:48 AM
Unknown Object (File)
Sun, Apr 21, 2:32 PM
Unknown Object (File)
Fri, Apr 19, 6:10 PM
Subscribers
None

Details

Summary

Ref T10978. This was introduced in D6923 in 2013 as a deprecated method (before methods were extensible) and has only ever been deprecated. It no longer works after D17250 (despite my mistaken claim there that we never had an API for actions), and has been superceded by diffusion.commit.edit which is a modern, fully-power method.

Test Plan

Viewed Conduit console, no longer saw method.

Diff Detail

Repository
rP Phabricator
Branch
audit6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15387
Build 20267: Run Core Tests
Build 20266: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 26 2017, 8:25 PM
This revision was automatically updated to reflect the committed changes.