HomePhabricator

Allow menu items to render their own content; make Dashboard items render on…

Tags
None
Referenced Files
F2508571: Screen Shot 2017-01-26 at 12.13.50 PM.png
Jan 26 2017, 8:57 PM
F2508568: Screen Shot 2017-01-26 at 12.09.24 PM.png
Jan 26 2017, 8:57 PM
Subscribers
Tokens
"Love" token, awarded by 20after4.

Description

Allow menu items to render their own content; make Dashboard items render on-page

Summary:
Ref T11957. When you click a dashboard item, it now sends you to /<app>/item/view/123/, which renders the proper crumbs, navigation, etc., with the dashboard as page content.

This works as you'd expect in Projects:

Screen Shot 2017-01-26 at 12.09.24 PM.png (1×1 px, 449 KB)

It's sliiiightly odd in Favorites since we nuke the nav menu, but seems basically fine?

Screen Shot 2017-01-26 at 12.13.50 PM.png (951×1 px, 127 KB)

Test Plan:

  • Created a dashboard panel on a project.
  • Clicked it, saw it render.
  • Made it the default panel, viewed project default screen, saw dashboard.
  • Disabled every panel I could, still saw reasonable behavior (this is silly anyway).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11957

Differential Revision: https://secure.phabricator.com/D17255

Details

Provenance
epriestleyAuthored on Jan 26 2017, 8:14 PM
epriestleyPushed on Jan 26 2017, 8:57 PM
Reviewer
chad
Differential Revision
D17255: Allow menu items to render their own content; make Dashboard items render on-page
Parents
rP3b8e2739fca0: Update some Audit documentation
Branches
Unknown
Tags
Unknown
Tasks
T11957: Add MenuEngine to Home
Build Status
Buildable 15389
Build 20270: Run Core Tests