Differential D17222

Attempt to make dropdown item actions more consistent
ClosedPublic
Actions

Authored by epriestley on Jan 18 2017, 7:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:59 AM

	Unknown Object (File)
	Fri, Apr 19, 6:07 PM

	Unknown Object (File)
	Mon, Apr 15, 9:37 AM

	Unknown Object (File)
	Mon, Apr 15, 9:31 AM

	Unknown Object (File)
	Mon, Apr 15, 3:32 AM

	Unknown Object (File)
	Wed, Apr 10, 5:32 PM

	Unknown Object (File)
	Mon, Apr 8, 9:22 AM

	Unknown Object (File)
	Mon, Apr 8, 5:36 AM

Subscribers

None

Details

Reviewers

Commits

rP45c3aaeb269e: Attempt to make dropdown item actions more consistent

Summary

See D17210. Currently, this handler needs to be installed on each menu that doesn't build with the default behavior.

Rather than copy-pasting it to the user menu, try to make it a default behavior. This adds a new rule: don't close the menu if the item is a dynamic item built in JS with PHUIXActionView.

This allows dynamic items to control the menu themselves, while giving static items the desired default behavior.

Test Plan

Opened menus on: dashboards, user menu, timeline comments. Clicked stuff. Menus went away.
Other menus still seemed to work right: Diffusion, Favorites, mobile menu.

Diff Detail

Repository

Branch

jsmenu1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15312
Build 20154: Run Core Tests
Build 20153: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 18 2017, 7:22 PM

No such luck: this breaks mobile "Action" menus on objects.

Harbormaster completed remote builds in B15312: Diff 41423.Jan 18 2017, 7:23 PM

Actually, something else already broke that.

C2a4am-UkAAlG7X.jpg (750×750 px, 55 KB)

After rebasing on D17223, I think everything (including the submenus in "Actions" on mobile on tasks) works correctly.

Harbormaster completed remote builds in B15314: Diff 41425.Jan 18 2017, 7:34 PM

chad accepted this revision.Jan 18 2017, 8:33 PM

This revision is now accepted and ready to land.Jan 18 2017, 8:33 PM

Closed by commit rP45c3aaeb269e: Attempt to make dropdown item actions more consistent (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2017, 9:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP90258ed491d5: Fix property shadowing on ActionListView after conversion to TagView.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

66 lines

webroot/

rsrc/

js/

application/

projects/

behavior-project-boards.js

7 lines

phui/

behavior-phui-dropdown-menu.js

14 lines

phuix/

PHUIXActionView.js

2 lines

PHUIXDropdownMenu.js

28 lines

Diff 41423

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/projects/behavior-project-boards.js

Loading...

webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js

Loading...

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

Loading...