Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
F15403118: D17223.id41431.diff
Tue, Mar 18, 1:57 AM
F15390140: D17223.id41424.diff
Sat, Mar 15, 5:56 AM
Unknown Object (File)
Fri, Feb 21, 3:06 PM
Unknown Object (File)
Feb 9 2025, 3:09 AM
Unknown Object (File)
Feb 9 2025, 3:09 AM
Unknown Object (File)
Feb 9 2025, 3:09 AM
Unknown Object (File)
Jan 30 2025, 12:22 AM
Unknown Object (File)
Jan 29 2025, 6:05 AM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable