Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 11:13 AM
Unknown Object (File)
Thu, May 29, 10:42 AM
Unknown Object (File)
Thu, May 29, 8:59 AM
Unknown Object (File)
Wed, May 28, 5:35 PM
Unknown Object (File)
May 1 2025, 10:15 AM
Unknown Object (File)
Apr 28 2025, 12:08 AM
Unknown Object (File)
Apr 11 2025, 7:40 PM
Unknown Object (File)
Mar 30 2025, 11:13 PM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable