Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
F19619700: D17223.id41431.diff
Wed, Feb 4, 10:39 AM
F19615368: D17223.id.diff
Tue, Feb 3, 11:56 PM
F19516015: D17223.diff
Wed, Jan 14, 6:28 PM
F19228516: D17223.id.diff
Dec 20 2025, 2:21 AM
F19068810: D17223.id41431.diff
Nov 30 2025, 12:39 PM
F19029544: D17223.diff
Nov 24 2025, 6:31 PM
F19026479: D17223.diff
Nov 24 2025, 10:49 AM
F18988835: D17223.id.diff
Nov 18 2025, 7:54 AM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable