Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:32 AM
Unknown Object (File)
Sat, Apr 6, 8:41 PM
Unknown Object (File)
Thu, Apr 4, 9:54 PM
Unknown Object (File)
Sat, Mar 30, 3:32 PM
Unknown Object (File)
Mar 20 2024, 6:22 AM
Unknown Object (File)
Mar 16 2024, 3:26 AM
Unknown Object (File)
Mar 16 2024, 3:26 AM
Unknown Object (File)
Mar 8 2024, 9:41 PM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable