Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
F18783473: D17223.id41431.diff
Mon, Oct 13, 6:59 AM
F18775009: D17223.id41424.diff
Fri, Oct 10, 5:39 PM
F18741529: D17223.diff
Thu, Oct 2, 1:38 PM
F18630475: D17223.id41431.diff
Sep 16 2025, 11:45 AM
F18619024: D17223.diff
Sep 15 2025, 1:32 AM
F18566062: D17223.id.diff
Sep 9 2025, 2:16 PM
F18500486: D17223.diff
Sep 4 2025, 9:06 PM
F18408468: D17223.id41424.diff
Aug 30 2025, 2:44 AM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable