Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic
Actions

Authored by epriestley on Jan 18 2017, 7:32 PM.

Tags

None

Referenced Files

	F15490681: D17223.id41424.diff
	Fri, Apr 11, 7:40 PM

	F15458357: D17223.id41431.diff
	Sun, Mar 30, 11:13 PM

	F15456508: D17223.id.diff
	Sun, Mar 30, 10:15 AM

	F15450999: D17223.diff
	Fri, Mar 28, 7:36 PM

	F15446651: D17223.id41431.diff
	Thu, Mar 27, 7:40 PM

	F15446650: D17223.id41424.diff
	Thu, Mar 27, 7:40 PM

	F15446649: D17223.id.diff
	Thu, Mar 27, 7:40 PM

	F15444514: D17223.id41424.diff
	Thu, Mar 27, 9:51 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP90258ed491d5: Fix property shadowing on ActionListView after conversion to TagView

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan