Page MenuHomePhabricator

Fix property shadowing on ActionListView after conversion to TagView
ClosedPublic

Authored by epriestley on Jan 18 2017, 7:32 PM.
Tags
None
Referenced Files
F14707312: D17223.diff
Fri, Jan 17, 5:30 AM
Unknown Object (File)
Sun, Dec 29, 12:37 AM
Unknown Object (File)
Sat, Dec 28, 3:53 PM
Unknown Object (File)
Thu, Dec 19, 6:57 PM
Unknown Object (File)
Dec 14 2024, 7:29 PM
Unknown Object (File)
Dec 9 2024, 6:36 AM
Unknown Object (File)
Dec 3 2024, 11:21 AM
Unknown Object (File)
Nov 20 2024, 10:31 AM
Subscribers
None

Details

Summary

See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan
  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable