Page MenuHomePhabricator

Hide dropdown menus when users click workflow items
ClosedPublic

Authored by epriestley on Jan 16 2017, 9:33 PM.
Tags
None
Referenced Files
F15387454: D17210.diff
Sat, Mar 15, 2:25 AM
F15385650: D17210.id.diff
Fri, Mar 14, 11:03 PM
F15380312: D17210.diff
Fri, Mar 14, 2:29 AM
F15379448: D17210.diff
Thu, Mar 13, 9:15 PM
Unknown Object (File)
Fri, Feb 21, 3:05 PM
Unknown Object (File)
Feb 10 2025, 9:30 AM
Unknown Object (File)
Feb 8 2025, 4:08 PM
Unknown Object (File)
Jan 29 2025, 11:42 PM
Subscribers
None

Details

Summary

In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan
  • Menu still stays open when toggling submenus like "Edit Related Objects".
  • Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable