Page MenuHomePhabricator

Hide dropdown menus when users click workflow items
ClosedPublic

Authored by epriestley on Jan 16 2017, 9:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:06 PM
Unknown Object (File)
Thu, Apr 11, 9:09 AM
Unknown Object (File)
Mon, Apr 8, 12:31 PM
Unknown Object (File)
Mon, Apr 8, 10:59 AM
Unknown Object (File)
Mon, Apr 8, 7:06 AM
Unknown Object (File)
Mon, Apr 8, 12:01 AM
Unknown Object (File)
Thu, Apr 4, 10:36 PM
Unknown Object (File)
Wed, Apr 3, 10:50 PM
Subscribers
None

Details

Summary

In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan
  • Menu still stays open when toggling submenus like "Edit Related Objects".
  • Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable