Page MenuHomePhabricator

Hide dropdown menus when users click workflow items
ClosedPublic

Authored by epriestley on Jan 16 2017, 9:33 PM.
Tags
None
Referenced Files
F19096873: D17210.id.diff
Dec 4 2025, 11:14 AM
F19094053: D17210.diff
Dec 3 2025, 11:07 PM
F18863393: D17210.diff
Nov 2 2025, 11:06 PM
F18814019: D17210.id41392.diff
Oct 20 2025, 8:49 PM
F18785895: D17210.diff
Oct 14 2025, 2:30 PM
F18740031: D17210.diff
Oct 2 2025, 12:10 AM
F18725386: D17210.id41393.diff
Sep 30 2025, 5:07 AM
F18642847: D17210.id41393.diff
Sep 19 2025, 12:55 AM
Subscribers
None

Details

Summary

In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan
  • Menu still stays open when toggling submenus like "Edit Related Objects".
  • Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable