Page MenuHomePhabricator

Hide dropdown menus when users click workflow items
ClosedPublic

Authored by epriestley on Jan 16 2017, 9:33 PM.
Tags
None
Referenced Files
F15467722: D17210.id41393.diff
Thu, Apr 3, 5:33 PM
F15455403: D17210.id41393.diff
Sun, Mar 30, 12:10 AM
F15449912: D17210.id.diff
Fri, Mar 28, 12:50 PM
F15447706: D17210.diff
Fri, Mar 28, 1:08 AM
F15444508: D17210.id41393.diff
Thu, Mar 27, 9:51 AM
F15444506: D17210.id41392.diff
Thu, Mar 27, 9:51 AM
F15444446: D17210.diff
Thu, Mar 27, 9:38 AM
F15441604: D17210.id41393.diff
Wed, Mar 26, 6:52 PM
Subscribers
None

Details

Summary

In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan
  • Menu still stays open when toggling submenus like "Edit Related Objects".
  • Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable