Page MenuHomePhabricator

Hide dropdown menus when users click workflow items
ClosedPublic

Authored by epriestley on Jan 16 2017, 9:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 15, 2:37 PM
Unknown Object (File)
Apr 14 2026, 9:39 PM
Unknown Object (File)
Apr 8 2026, 7:44 PM
Unknown Object (File)
Mar 15 2026, 6:54 PM
Unknown Object (File)
Mar 4 2026, 8:40 AM
Unknown Object (File)
Dec 4 2025, 11:14 AM
Unknown Object (File)
Dec 3 2025, 11:07 PM
Unknown Object (File)
Nov 2 2025, 11:06 PM
Subscribers
None

Details

Summary

In D16157, dropdown menus got an overly-broad check for not closing when an item is clicked.

Specifically, we don't want to close the menu if the item is really opening a submenu, like "Edit Related Objects..." does on mobile.

The check for this is too broad, and also doesn't close the menu if the item has workflow.

Instead, use a narrower check.

Test Plan
  • Menu still stays open when toggling submenus like "Edit Related Objects".
  • Menu now closes properly when using workflow items like "Edit Comment" or "Remove Comment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable