HomePhabricator

Fix property shadowing on ActionListView after conversion to TagView

Description

Fix property shadowing on ActionListView after conversion to TagView

Summary:
See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan:

  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17223

Details

Provenance
epriestleyAuthored on Jan 18 2017, 7:29 PM
epriestleyPushed on Jan 18 2017, 9:14 PM
Reviewer
chad
Differential Revision
D17223: Fix property shadowing on ActionListView after conversion to TagView
Parents
rP35f4514e3ff6: Fancier user menu
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15320
Build 20168: Run Core Tests