Page MenuHomePhabricator

Provide bucketing for commits in Audit
ClosedPublic

Authored by epriestley on Jan 12 2017, 6:31 PM.

Details

Summary

Fixes T9430. Fixes T9362. Fixes T9544. This changes the default view of Audit to work like Differential, where commits you need to audit or respond to are shown in buckets.

This is a bit messy and probably needs some followups. This stuff has changed from a compatibility viewpoint:

  • The query works differently now (but in a better, modern way), so existing saved queries will need to be updated.
  • I've removed the counters from the home page instead of updating them, since they're going to get wiped out by ProfileMenu soon anyway.
  • When bucketed queries return too many results (more than 1,000) we now show a warning about it. This isn't greaaaat but it seems good enough for now.
Test Plan

Screen Shot 2017-01-12 at 10.16.55 AM.png (1×1 px, 365 KB)

Diff Detail

Repository
rP Phabricator
Branch
commit14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/query/DiffusionCommitQuery.php:127XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15227
Build 20017: Run Core Tests
Build 20016: arc lint + arc unit