Page MenuHomePhabricator

Release: start adding changerequests
Changes PlannedPublic

Authored by avivey on Dec 9 2016, 10:16 PM.
Referenced Files
F10770435: D17020.diff
Sat, May 28, 4:27 AM
F10768821: D17020.id40969.diff
Fri, May 27, 6:45 PM
Unknown Object (File)
Wed, May 25, 10:38 AM
Unknown Object (File)
Apr 15 2017, 7:57 PM
Unknown Object (File)
Apr 15 2017, 7:57 PM
Unknown Object (File)
Apr 15 2017, 7:57 PM
Unknown Object (File)
Apr 15 2017, 7:57 PM
Unknown Object (File)
Apr 15 2017, 7:56 PM


Group Reviewers
Blessed Reviewers
Test Plan


Diff Detail

rP Phabricator
Lint Errors
Errorsrc/applications/release/ReleaseRenderEventListener.php:43XHP5Use of Undeclared Variable
Warningresources/sql/autopatches/20161220.release.changes.sql:CHMOD1Invalid Executable
Warningsrc/applications/release/OPEN_QUESTIONS:11TXT3Line Too Long
Warningsrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:62TXT3Line Too Long
Warningsrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:65TXT3Line Too Long
Warningsrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:68TXT3Line Too Long
Warningsrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:71TXT3Line Too Long
Warningsrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:74TXT3Line Too Long
Warningsrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:85TXT3Line Too Long
Warningsrc/applications/release/phid/ReleaseChangeRequestPHIDType.php:CHMOD1Invalid Executable
Warningsrc/applications/release/phid/ReleaseChangeRequestPHIDType.php:32TXT3Line Too Long
Warningsrc/applications/release/query/ReleaseChangeRequestQuery.php:144TXT3Line Too Long
Advicesrc/applications/release/changes/ReleaseChangeRequestImplementation.php:26XHP16TODO Comment
Advicesrc/applications/release/changes/actions/ReleaseChangeRequestAction.php:31XHP16TODO Comment
Advicesrc/applications/release/conduit/PhabricatorReleaseReleaseEditConduitAPIMethod.php:7XHP16TODO Comment
Advicesrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:22XHP16TODO Comment
Advicesrc/applications/release/controller/ReleaseChangeRequestFromRevisionController.php:93XHP16TODO Comment
Advicesrc/applications/release/controller/ReleaseReleaseViewController.php:103XHP16TODO Comment
Advicesrc/applications/release/editor/ReleaseChangeRequestEditEngine.php:62XHP16TODO Comment
Advicesrc/applications/release/editor/ReleaseChangeRequestEditor.php:53XHP16TODO Comment
Advicesrc/applications/release/editor/ReleaseChangeRequestEditor.php:69XHP16TODO Comment
Advicesrc/applications/release/query/ReleaseChangeRequestQuery.php:107XHP16TODO Comment
Advicesrc/applications/release/query/ReleaseChangeRequestSearchEngine.php:72XHP16TODO Comment
Advicesrc/applications/release/storage/ReleaseChangeRequest.php:3XHP16TODO Comment
Advicesrc/applications/release/storage/ReleaseChangeRequest.php:16XHP16TODO Comment
Tests Skipped
Build Status
Buildable 15002
Build 19673: Run Core Tests
Build 19672: arc lint + arc unit

Event Timeline

avivey retitled this revision from to Release: start adding changerequests.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey edited edge metadata.
  • wip still

Editing, Actions, Controller, List All.

  • $release->canAcceptChangeRequests()
  • conduit .edit, .search methods
  • db migrations
  • custom fields

@epriestley: When you have a chance, I've gathered some mostly-technical questions that I'd like your input on:

  • expandTransaction: Because I decided to implement "custom actions" using transactions (P2009), I ended up having xactions that are shown on the timeline ("avive has frozen this release"), but their actual work is been handled by another xaction ("CloseBranchTransaction"). expandTransaction is how the old transaction code handled this, but it didn't make it to the modular code. Should I just find a new way to do it?
  • What kind of Edges do we need? RepositoryInRelease, ObjectRequestedAsChangeForRelease, ChangeRequestInRelease, ?
  • Should Change Request have their own policy, subscribers, comments, etc.?
  • Transactions Metadata: That one didn't make the cut for modular-transactions either. For the case of "Updates on CR show up on the Release page", they would be very useful. Do we hate it?
  • In Releeph, there's a "want" status, that's corresponds to Differential's Accept, and distinct from "Pull" status. Is that an important enough feature to include as first-class? Is there a way to include something like that (A user->value mapping) as a Custom Field?
  • EditEngine::buildCustomEditFields(): Why don't we move the field definitions into the *TransactionType classes, and then use reflection to implement this method? It looks like there's a 1-1 relation between fields and xaction types.

Check policy when requesting a new change