Page MenuHomePhabricator

Initial code-dump of Release
Needs ReviewPublic

Authored by avivey on Dec 2 2016, 9:34 PM.

Details

Summary

This is a dump of the Release code I have.

  • I took over the X monogram, because it was free and the wordsmith said it looks like "cutting". I don't mind giving it up, but it kinda lead into Y for change/pull requests.
  • This is more-or-less useless without adding a lot of custom actions, such as "create branch", "close branch", "deploy release to server", etc. Many of them are straight T182, and some may be implemented as build plans.
  • The code for Custom Actions is completely outside of this change right now - It's basically Event Listener adding buttons + custom TransactionTypes (P2009).
  • Major missing features include Release Plan and Change Request, all the Pipeline (Automation) features, and Artifacts. I plan to start with Change Request or maybe Artifacts.

More technical debt (For follow-ups / future):

  • UI for create release: like in Add Build Step, first select Release Plan, then fill in the rest of the stuff. Right now, I need custom create forms because I don't yet have Release Plan objects.
  • None of this staff is abstracted over VCS yet - it's all git. Although this mostly effects terminology, because there's very little code that actually does things...
  • expand transaction: in a couple of cases I need to (Mostly because of the custom actions thing; Either move to base ApplicationEditor, or find another solution on my end.
  • Release Statuses are a hard-coded list right now, but should probably be customizable at some point.
  • Edges: RepositoryInRelease?

Ref T9530

Test Plan

Mostly checked in the context of follow-up diffs :-/

Event Timeline

avivey updated this revision to Diff 40860.Dec 2 2016, 9:34 PM
avivey retitled this revision from to Very initial code-dump of Release.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, hach-que.

@epriestley: I'm not exactly sure this is ready, but this part of the code hasn't changed much recently.

avivey updated this object.Dec 2 2016, 10:40 PM
avivey edited edge metadata.
avivey updated this object.Dec 9 2016, 3:02 AM
chad added a subscriber: chad.Dec 9 2016, 3:13 AM
chad added inline comments.
src/applications/release/application/PhabricatorReleaseApplication.php
23

frowncat

avivey added inline comments.Dec 9 2016, 3:22 AM
src/applications/release/xaction/PhabricatorReleaseReleaseTransactionType.php
7 ↗(On Diff #40860)

Is this one better?

avivey added a child revision: Restricted Differential Revision.Dec 9 2016, 10:10 PM
avivey edited child revisions, added: D17020: Release: start adding changerequests; removed: Restricted Differential Revision.Dec 9 2016, 10:19 PM
avivey updated this revision to Diff 41025.Dec 14 2016, 6:57 PM

Add a Demo Template object to allow testing, and add some TODOs.

avivey planned changes to this revision.Dec 14 2016, 6:57 PM
avivey updated this revision to Diff 41113.EditedDec 17 2016, 1:31 AM
avivey marked an inline comment as done.
  • Support custom fields; Some minor stuff.
  • add TODO and OPEN_QUESTIONS files.
avivey planned changes to this revision.Dec 17 2016, 1:31 AM
avivey updated this revision to Diff 41128.Dec 20 2016, 9:37 PM
  • Check that mail works
  • Policy to Create new Release
  • normalize filenames
avivey planned changes to this revision.Dec 20 2016, 9:37 PM
eadler added a subscriber: eadler.Jan 4 2017, 5:52 PM
avivey updated this revision to Diff 41521.Jan 28 2017, 4:35 PM

this part is mostly done (Still not actually usable)

avivey retitled this revision from Very initial code-dump of Release to Initial code-dump of Release.Jan 28 2017, 4:41 PM
avivey edited the summary of this revision. (Show Details)
avivey edited the test plan for this revision. (Show Details)
hach-que resigned from this revision.Mar 18 2017, 5:25 AM