Page MenuHomePhabricator

Improve settings caches on fast paths like Conduit
ClosedPublic

Authored by epriestley on Dec 6 2016, 1:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:45 AM
Unknown Object (File)
Wed, Apr 3, 3:02 PM
Unknown Object (File)
Sat, Mar 30, 3:20 AM
Unknown Object (File)
Thu, Mar 28, 6:23 AM
Unknown Object (File)
Tue, Mar 26, 7:16 PM
Unknown Object (File)
Tue, Mar 26, 7:16 PM
Unknown Object (File)
Tue, Mar 26, 7:16 PM
Unknown Object (File)
Tue, Mar 26, 7:15 PM
Subscribers
None

Details

Summary

Ref T11954. This reduces how much work we need to do to load settings, particularly for Conduit (which currently can not benefit directly from the user cache, because it loads the user indirectly via a token).

Specifically:

  • Cache builtin defaults in the runtime cache. This means Phabricator may need to be restarted if you change a global setting default, but this is exceptionally rare.
  • Cache global defaults in the mutable cache. This means we do less work to load them.
  • Avoid loading settings classes if we don't have to.
  • If we missed the user cache for settings, try to read it from the cache table before we actually go regenerate it (we miss on Conduit pathways).
Test Plan

Used ab -n100 ... to observe a ~6-10ms performance improvement for user.whoami.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable