Page MenuHomePhabricator

Validate settings before writing them to the user cache
ClosedPublic

Authored by epriestley on Dec 7 2016, 8:51 PM.
Tags
None
Referenced Files
F12835131: D17008.diff
Thu, Mar 28, 3:00 PM
Unknown Object (File)
Mon, Mar 25, 7:34 AM
Unknown Object (File)
Mon, Mar 25, 7:34 AM
Unknown Object (File)
Mon, Mar 25, 6:20 AM
Unknown Object (File)
Mon, Mar 25, 6:19 AM
Unknown Object (File)
Jan 30 2024, 6:53 AM
Unknown Object (File)
Jan 23 2024, 9:37 AM
Unknown Object (File)
Jan 20 2024, 7:40 PM
Subscribers
None

Details

Summary

Fixes T11960. In D16998 I removed some code which validated settings on read to improve performance, but lost this replacement validation in shuffling the patch stack.

This restores similar validation before we write the cache. This has the same effect, it's just faster.

Also, bump the cache key to wipe out anything that got bitten (like my account on secure rendering dates wrong).

Test Plan
  • Edited settings, verified the edits held.
  • Faked invalid settings, saw the check throw exceptions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40918.
epriestley retitled this revision from to Validate settings before writing them to the user cache.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Really, truly bump that cache key.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 7 2016, 9:32 PM
This revision was automatically updated to reflect the committed changes.