Page MenuHomePhabricator

Don't let users write summaries or test plans which will become ambiguous in commit messages
ClosedPublic

Authored by epriestley on Nov 12 2016, 3:14 PM.
Tags
None
Referenced Files
F15558610: D16846.id.diff
Tue, Apr 29, 4:35 AM
F15555728: D16846.diff
Mon, Apr 28, 12:51 PM
F15540435: D16846.diff
Fri, Apr 25, 7:33 AM
F15488635: D16846.id.diff
Fri, Apr 11, 12:36 AM
F15485744: D16846.id40568.diff
Thu, Apr 10, 2:03 AM
F15453253: D16846.id40565.diff
Mar 29 2025, 10:29 AM
F15449582: D16846.id40565.diff
Mar 28 2025, 11:03 AM
F15448597: D16846.id.diff
Mar 28 2025, 5:53 AM
Subscribers
None

Details

Summary

Ref T11085. To recreate the issue:

  • From the web UI, click "Edit Revision".
  • Write something like this as your "Summary" (i.e., put another field marker, like "Test Plan:", into the summary):

This is a test of the
Test Plan: field to see
if it works.

  • Save changes.

Later, when the summary is amended into a commit message, the parser will see two "Test Plan:" fields and fail to parse the message.

Instead, prevent users from making this edit.

Test Plan

Screen Shot 2016-11-12 at 7.10.43 AM.png (846×2 px, 112 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable