Page MenuHomePhabricator

Don't let users write summaries or test plans which will become ambiguous in commit messages
ClosedPublic

Authored by epriestley on Nov 12 2016, 3:14 PM.
Tags
None
Referenced Files
F18094213: D16846.id.diff
Thu, Aug 7, 10:01 PM
F18093207: D16846.id40565.diff
Thu, Aug 7, 4:25 PM
F18091313: D16846.id40568.diff
Wed, Aug 6, 9:02 PM
F18090327: D16846.id40568.diff
Wed, Aug 6, 3:14 PM
F18082225: D16846.id.diff
Tue, Aug 5, 4:44 AM
F17926614: D16846.diff
Wed, Jul 30, 1:26 PM
Unknown Object (File)
Jul 5 2025, 4:30 PM
Unknown Object (File)
Jul 1 2025, 5:02 AM
Subscribers
None

Details

Summary

Ref T11085. To recreate the issue:

  • From the web UI, click "Edit Revision".
  • Write something like this as your "Summary" (i.e., put another field marker, like "Test Plan:", into the summary):

This is a test of the
Test Plan: field to see
if it works.

  • Save changes.

Later, when the summary is amended into a commit message, the parser will see two "Test Plan:" fields and fail to parse the message.

Instead, prevent users from making this edit.

Test Plan

Screen Shot 2016-11-12 at 7.10.43 AM.png (846×2 px, 112 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable