Page MenuHomePhabricator

Don't let users write summaries or test plans which will become ambiguous in commit messages
ClosedPublic

Authored by epriestley on Nov 12 2016, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 5, 4:13 AM
Unknown Object (File)
Wed, Aug 3, 8:17 PM
Unknown Object (File)
Wed, Aug 3, 7:38 PM
Unknown Object (File)
Tue, Jul 26, 5:22 AM
Unknown Object (File)
Sat, Jul 23, 5:54 AM
Unknown Object (File)
Thu, Jul 21, 6:51 PM
Unknown Object (File)
Wed, Jul 20, 1:40 PM
Unknown Object (File)
Jul 14 2022, 7:40 AM
Subscribers
None

Details

Summary

Ref T11085. To recreate the issue:

  • From the web UI, click "Edit Revision".
  • Write something like this as your "Summary" (i.e., put another field marker, like "Test Plan:", into the summary):

This is a test of the
Test Plan: field to see
if it works.

  • Save changes.

Later, when the summary is amended into a commit message, the parser will see two "Test Plan:" fields and fail to parse the message.

Instead, prevent users from making this edit.

Test Plan

Screen Shot 2016-11-12 at 7.10.43 AM.png (846×2 px, 112 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable