Page MenuHomePhabricator

Allow EditEngine to build NUX buttons that point at the right place

Authored by epriestley on Nov 3 2016, 6:24 PM.



Fixes T11812.

  • Pull the logic for building the "Create Whatever" dropdown out.
  • Use it to generate NUX buttons, too.
  • Use the new logic in Paste and Maniphest.
Test Plan
  • Viewed Paste NUX, button worked.
  • Viewed Maniphest NUX with multiple create forms, button worked.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow EditEngine to build NUX buttons that point at the right place.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.
avivey added inline comments.

Maybe respect $spec['disabled'] and 'workflow' here too, just in case?

This revision is now accepted and ready to land.Nov 3 2016, 7:57 PM
epriestley edited edge metadata.
  • Respect disabled/workflow on items, just in case.
This revision was automatically updated to reflect the committed changes.