Page MenuHomePhabricator
Differential D16797

Allow EditEngine to build NUX buttons that point at the right place
ClosedPublic
Actions

Authored by epriestley on Nov 3 2016, 6:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 4:06 AM
Unknown Object (File)
Fri, Dec 13, 1:29 PM
Unknown Object (File)
Sat, Dec 7, 4:18 PM
Unknown Object (File)
Mon, Nov 25, 1:59 AM
Unknown Object (File)
Wed, Nov 20, 9:36 PM
Unknown Object (File)
Mon, Nov 18, 10:06 PM
Unknown Object (File)
Nov 18 2024, 7:16 PM
Unknown Object (File)
Nov 17 2024, 2:35 AM
View All Files
Subscribers
avivey

Details

Reviewers
avivey
chad
Maniphest Tasks
T11812: "Create a Paste" button on welcome page doesn't work
Commits
rP0f1785c0aa8c: Allow EditEngine to build NUX buttons that point at the right place
Summary

Fixes T11812.

  • Pull the logic for building the "Create Whatever" dropdown out.
  • Use it to generate NUX buttons, too.
  • Use the new logic in Paste and Maniphest.
Test Plan
  • Viewed Paste NUX, button worked.
  • Viewed Maniphest NUX with multiple create forms, button worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40454.Nov 3 2016, 6:24 PM
epriestley retitled this revision from to Allow EditEngine to build NUX buttons that point at the right place.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11812: "Create a Paste" button on welcome page doesn't work.
avivey accepted this revision.Nov 3 2016, 7:57 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.
avivey added inline comments.
src/applications/transactions/editengine/PhabricatorEditEngine.php
1394

Maybe respect $spec['disabled'] and 'workflow' here too, just in case?

This revision is now accepted and ready to land.Nov 3 2016, 7:57 PM
epriestley updated this revision to Diff 40457.Nov 4 2016, 4:50 PM
epriestley edited edge metadata.
  • Respect disabled/workflow on items, just in case.
Closed by commit rP0f1785c0aa8c: Allow EditEngine to build NUX buttons that point at the right place (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2016, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
10 lines
paste/
query/
10 lines
transactions/
editengine/
137 lines

Diff 40458

View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility