Page MenuHomePhabricator

Allow EditEngine to build NUX buttons that point at the right place
ClosedPublic

Authored by epriestley on Nov 3 2016, 6:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 2:23 AM
Unknown Object (File)
Feb 20 2024, 6:36 AM
Unknown Object (File)
Feb 5 2024, 7:30 PM
Unknown Object (File)
Jan 23 2024, 4:20 PM
Unknown Object (File)
Dec 30 2023, 7:00 PM
Unknown Object (File)
Dec 27 2023, 7:57 AM
Unknown Object (File)
Dec 27 2023, 7:57 AM
Unknown Object (File)
Dec 27 2023, 7:57 AM
Subscribers

Details

Summary

Fixes T11812.

  • Pull the logic for building the "Create Whatever" dropdown out.
  • Use it to generate NUX buttons, too.
  • Use the new logic in Paste and Maniphest.
Test Plan
  • Viewed Paste NUX, button worked.
  • Viewed Maniphest NUX with multiple create forms, button worked.

Diff Detail

Repository
rP Phabricator
Branch
edit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14344
Build 18674: Run Core Tests
Build 18673: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow EditEngine to build NUX buttons that point at the right place.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.
avivey added inline comments.
src/applications/transactions/editengine/PhabricatorEditEngine.php
1394

Maybe respect $spec['disabled'] and 'workflow' here too, just in case?

This revision is now accepted and ready to land.Nov 3 2016, 7:57 PM
epriestley edited edge metadata.
  • Respect disabled/workflow on items, just in case.
This revision was automatically updated to reflect the committed changes.