Link to badge view from people profile view
ClosedPublic
Actions

Authored by jcox on Sep 27 2016, 7:27 PM.

Tags

None

Referenced Files

	F13137947: D16604.diff
	Thu, May 2, 9:39 PM

	Unknown Object (File)
	Mon, Apr 29, 5:54 PM

	Unknown Object (File)
	Sat, Apr 27, 1:37 AM

	Unknown Object (File)
	Thu, Apr 25, 7:45 AM

	Unknown Object (File)
	Thu, Apr 25, 3:31 AM

	Unknown Object (File)
	Tue, Apr 16, 3:51 PM

	Unknown Object (File)
	Thu, Apr 11, 10:48 AM

	Unknown Object (File)
	Fri, Apr 5, 6:20 AM

View All Files

Subscribers

epriestley

yelirekim

Tokens

"Party Time" token, awarded by epriestley.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10715: Badge name on badge cards should be a link to the badge page

Commits

rP0fc05ab47edd: Link to badge view from people profile view

Summary

Fixes T10715. Badges on the profile view now link to the badge view

Test Plan

Went to the profile view and clicked the link.

Diff Detail

Repository

rP Phabricator

Branch

BadgeLink

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13863
Build 17936: Run Core Tests
Build 17935: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39974.Sep 27 2016, 7:27 PM

jcox retitled this revision from to Link to badge view from people profile view.

jcox updated this object.

jcox edited the test plan for this revision. (Show Details)

jcox added a task: T10715: Badge name on badge cards should be a link to the badge page.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 27 2016, 7:27 PM

Herald added subscribers: yelirekim, epriestley. · View Herald Transcript

whelp okay then

This revision is now accepted and ready to land.Sep 27 2016, 7:30 PM

epriestley awarded a token.Sep 27 2016, 7:30 PM

Closed by commit rP0fc05ab47edd: Link to badge view from people profile view (authored by jcox, committed by jcox). · Explain WhySep 27 2016, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileViewController.php

1 line

Diff 39974

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Link to badge view from people profile viewClosedPublicActions