Page MenuHomePhabricator
Differential D16602

Remove "Application" field from ConduitSearchEngine
ClosedPublic
Actions

Authored by jcox on Sep 27 2016, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 11:38 PM
Unknown Object (File)
Wed, Apr 10, 5:42 AM
Unknown Object (File)
Wed, Apr 3, 10:28 PM
Unknown Object (File)
Tue, Apr 2, 6:46 PM
Unknown Object (File)
Sun, Mar 31, 3:09 AM
Unknown Object (File)
Mar 18 2024, 4:23 AM
Unknown Object (File)
Mar 17 2024, 9:30 AM
Unknown Object (File)
Mar 17 2024, 9:30 AM
View All Files
Subscribers
epriestley
Korvin
yelirekim

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9063: Conduit application search
Commits
rP6649b0cef890: Remove "Application" field from ConduitSearchEngine
Summary

Fixes T9063. Removes the "Application" field from the search because it was largely redundant with the 'Name Contains' field.

Test Plan

Went to /conduit/query/modern/, clicked on Edit Query and noted that there is no "Application" field anymore. The 'Name Contains' field still works however.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox updated this revision to Diff 39969.Sep 27 2016, 5:53 PM
jcox retitled this revision from to Remove "Application" field from ConduitSearchEngine.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T9063: Conduit application search.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 27 2016, 5:53 PM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
epriestley requested changes to this revision.Sep 27 2016, 5:56 PM
epriestley added a reviewer: epriestley.

Nice. Let's get rid of the withApplicationNames() method completely? I don't see any other callers...

This revision now requires changes to proceed.Sep 27 2016, 5:56 PM
jcox updated this revision to Diff 39970.Sep 27 2016, 5:59 PM
jcox edited edge metadata.

DELETE MOARRR CODE

Herald added a subscriber: Korvin. · View Herald TranscriptSep 27 2016, 5:59 PM
epriestley added inline comments.Sep 27 2016, 5:59 PM
src/applications/conduit/query/PhabricatorConduitMethodQuery.php
83–84

!!!

epriestley accepted this revision.Sep 27 2016, 5:59 PM
epriestley edited edge metadata.

With that last bit, I think that's everything. Thanks!

This revision is now accepted and ready to land.Sep 27 2016, 5:59 PM
jcox updated this revision to Diff 39971.Sep 27 2016, 6:32 PM
jcox edited edge metadata.

removed another vestige of application names

Closed by commit rP6649b0cef890: Remove "Application" field from ConduitSearchEngine (authored by jcox, committed by jcox). · Explain WhySep 27 2016, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
query/
16 lines
22 lines

Diff 39972

View Options

src/applications/conduit/query/PhabricatorConduitMethodQuery.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Loading...
Phabricator · Built by Phacility