Fixes T9063. Removes the "Application" field from the search because it was largely redundant with the 'Name Contains' field.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9063: Conduit application search
- Commits
- rP6649b0cef890: Remove "Application" field from ConduitSearchEngine
Went to /conduit/query/modern/, clicked on Edit Query and noted that there is no "Application" field anymore. The 'Name Contains' field still works however.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- RemoveAppType
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 13858 Build 17927: Run Core Tests Build 17926: arc lint + arc unit
Event Timeline
Comment Actions
Nice. Let's get rid of the withApplicationNames() method completely? I don't see any other callers...
src/applications/conduit/query/PhabricatorConduitMethodQuery.php | ||
---|---|---|
84–93 ↗ | (On Diff #39970) | !!! |