Page MenuHomePhabricator
Differential D16587

Fix URI for Phurl NUX
ClosedPublic
Actions

Authored by epriestley on Sep 22 2016, 9:41 PM.
Tags
None
Referenced Files
F14031970: D16587.diff
Sat, Nov 9, 12:25 PM
F13990760: D16587.id39929.diff
Tue, Oct 22, 5:55 AM
F13984775: D16587.id39928.diff
Sun, Oct 20, 3:52 PM
F13984571: D16587.diff
Sun, Oct 20, 2:20 PM
Unknown Object (File)
Oct 2 2024, 8:18 AM
Unknown Object (File)
Sep 16 2024, 12:02 AM
Unknown Object (File)
Sep 16 2024, 12:02 AM
Unknown Object (File)
Sep 16 2024, 12:02 AM
View All Files
Subscribers
None
Tokens
"Manufacturing Defect?" token, awarded by jcox.

Details

Reviewers
chad
jcox
Maniphest Tasks
T11685: Phurl "Shorten a URL" 404s
Commits
rP88ff486aaeee: Fix URI for Phurl NUX
Summary

Fixes T11685. We missed this one straggler the recent conversion of Phurl to EditEngine, in T10673.

Test Plan

Visited /phurl/?nux=1, clicked "Shorten a URL".

Diff Detail

Repository
rP Phabricator
Branch
phurlnux1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13814
Build 17854: Run Core Tests
Build 17853: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39928.Sep 22 2016, 9:41 PM
epriestley retitled this revision from to Fix URI for Phurl NUX.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, jcox.
epriestley added a task: T11685: Phurl "Shorten a URL" 404s.
jcox accepted this revision.Sep 22 2016, 9:43 PM
jcox edited edge metadata.
This revision is now accepted and ready to land.Sep 22 2016, 9:43 PM
jcox awarded a token.Sep 22 2016, 9:43 PM
epriestley added a comment.Sep 22 2016, 9:45 PM

Not-obvious notes about this:

  • NUX is New User Experience, i.e. what users see the first time they use Phabricator.
  • When you visit applications for the first time, you usually get a one-off welcome/NUX view that says "Hey welcome to this app, it is good and cool".
  • You can get to this view explicitly with ?nux=true to test it, e.g. /phurl/?nux=true.
  • We've forgotten to fix this link like 8 times in a row now. 🤷 ¯\_(ツ)_/¯
Closed by commit rP88ff486aaeee: Fix URI for Phurl NUX (authored by epriestley, committed by epriestley). · Explain WhySep 22 2016, 9:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phurl/
query/
5 lines

Diff 39928

View Options

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

Loading...
Phabricator · Built by Phacility