Paths

Table of Contentst

Differential D16587

Fix URI for Phurl NUX
ClosedPublic
Actions

Authored by epriestley on Sep 22 2016, 9:41 PM.

Tags

None

Referenced Files

	F13235210: D16587.diff
	Tue, May 21, 4:27 AM

	F13230039: D16587.id.diff
	Mon, May 20, 8:18 PM

	F13216722: D16587.diff
	Sat, May 18, 1:59 AM

	F13214298: D16587.diff
	Fri, May 17, 9:45 AM

	F13201362: D16587.id.diff
	Tue, May 14, 11:19 AM

	F13200037: D16587.id39929.diff
	Mon, May 13, 9:38 PM

	F13197998: D16587.diff
	Mon, May 13, 2:50 AM

	F13181686: D16587.diff
	Thu, May 9, 2:40 PM

Subscribers

None

Tokens

"Manufacturing Defect?" token, awarded by jcox.

Details

Reviewers

chad
jcox

Maniphest Tasks

T11685: Phurl "Shorten a URL" 404s

Commits

rP88ff486aaeee: Fix URI for Phurl NUX

Summary

Fixes T11685. We missed this one straggler the recent conversion of Phurl to EditEngine, in T10673.

Test Plan

Visited /phurl/?nux=1, clicked "Shorten a URL".

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39928.Sep 22 2016, 9:41 PM

epriestley retitled this revision from to Fix URI for Phurl NUX.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, jcox.

epriestley added a task: T11685: Phurl "Shorten a URL" 404s.

jcox accepted this revision.Sep 22 2016, 9:43 PM

jcox edited edge metadata.

This revision is now accepted and ready to land.Sep 22 2016, 9:43 PM

jcox awarded a token.Sep 22 2016, 9:43 PM

Not-obvious notes about this:

NUX is New User Experience, i.e. what users see the first time they use Phabricator.
When you visit applications for the first time, you usually get a one-off welcome/NUX view that says "Hey welcome to this app, it is good and cool".
You can get to this view explicitly with ?nux=true to test it, e.g. /phurl/?nux=true.
We've forgotten to fix this link like 8 times in a row now. 🤷 ¯\_(ツ)_/¯

Closed by commit rP88ff486aaeee: Fix URI for Phurl NUX (authored by epriestley, committed by epriestley). · Explain WhySep 22 2016, 9:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

query/

PhabricatorPhurlURLSearchEngine.php

5 lines

Diff 39929

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

Loading...