Update Diviner for array-valued `@doc-stuff` return values from DocblockParser
ClosedPublic
Actions

Authored by epriestley on Sep 2 2016, 11:53 AM.

Details

Reviewers

joshuaspence
yelirekim
chad

Maniphest Tasks

T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags"

Commits

rP1eee75496a5a: Update Diviner for array-valued `@doc-stuff` return values from DocblockParser

Summary

Ref T11575. After D16431, the parser may return arrays.

Test Plan

Ran bin/diviner generate --clean in phabricator/ without errors. Previously, this raised some parsing errors related to getting arrays where strings were expected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39665.Sep 2 2016, 11:53 AM

epriestley retitled this revision from to Update Diviner for array-valued `@doc-stuff` return values from DocblockParser.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, yelirekim, joshuaspence.

epriestley added a task: T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

joshuaspence accepted this revision.Sep 2 2016, 12:02 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Sep 2 2016, 12:02 PM

epriestley mentioned this in T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".Sep 2 2016, 12:24 PM

Closed by commit rP1eee75496a5a: Update Diviner for array-valued `@doc-stuff` return values from DocblockParser (authored by epriestley, committed by epriestley). · Explain WhySep 2 2016, 12:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

atomizer/

DivinerPHPAtomizer.php

11 lines

Diff 39667

View Options

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

Update Diviner for array-valued `@doc-stuff` return values from DocblockParserClosedPublicActions