Currently the tags of following docblock are parsed as array('special' => "foo\nbar"). This diff changes the output to be array('special' => array('foo', 'bar')).
/** * @special foo * @special bar */
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHU237549280f08: Improve parsing of docblock specials
Ran unit tests.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One inline -- and what does this produce (is there a test for it)?
@key value @key
| src/parser/PhutilDocblockParser.php | ||
|---|---|---|
| 121 | This seems a little odd to me, I'd expect: @morse-code dot @morse-code dot @morse-code dash ...or whatever to produce array('dot', 'dot', 'dash'). Is there a particular reason for it? | |
| src/parser/PhutilDocblockParser.php | ||
|---|---|---|
| 121 | Right, this was primarily intended for this case: @special @special @special In this case, I figured true was better than array(true, true, true). | |
Comment Actions
Ah, that makes sense for the no-strings case. Agreed that true is probably the right value there.
(I'm actually not really sure what I expect string + no string case to do.)
Comment Actions
Cool, those behaviors seem reasonable to me. Thanks!
(Does @stable @stable @stable have a test case?)