Page MenuHomePhabricator

Use new format for docblock specials when parsing symbols
ClosedPublic

Authored by yelirekim on Sep 2 2016, 4:58 AM.
Tags
None
Referenced Files
F18657091: D16484.id39666.diff
Tue, Sep 23, 12:28 AM
F18655626: D16484.diff
Mon, Sep 22, 8:23 PM
F18630980: D16484.id39666.diff
Tue, Sep 16, 1:50 PM
F18630660: D16484.id39662.diff
Tue, Sep 16, 12:22 PM
F18598555: D16484.diff
Sat, Sep 13, 5:17 AM
F18180303: D16484.id39662.diff
Aug 16 2025, 6:04 AM
F18141095: D16484.diff
Aug 14 2025, 6:00 AM
F18051459: D16484.id39662.diff
Aug 3 2025, 11:23 PM
Subscribers

Details

Summary

Fixes T11575. Before, specials used to be separated by newlines, now they are returned as an array for us, or returned as a single value for us. Casting the result to an array is the minimum amount of disruption we can incur here to keep the existing logic in place and provide the same values.

Test Plan
  • deleted my src/.phutil_module_cache from arcanist, libphutil and phabricator
  • ran arc liberate src in all of those places
  • ran all of their unit tests
  • saw all tests pass and no modifications made to __phutil_library_map__.php for any of the libraries

Diff Detail

Repository
rPHU libphutil
Branch
symbol_loader_docblock (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13537
Build 17426: Run Core Tests
Build 17425: arc lint + arc unit