Page MenuHomePhabricator

Use new format for docblock specials when parsing symbols
ClosedPublic

Authored by yelirekim on Sep 2 2016, 4:58 AM.
Tags
None
Referenced Files
F14019709: D16484.diff
Tue, Nov 5, 11:30 PM
F13999190: D16484.diff
Thu, Oct 24, 1:20 PM
F13982143: D16484.id39666.diff
Sat, Oct 19, 9:30 PM
F13974385: D16484.id.diff
Fri, Oct 18, 5:20 AM
Unknown Object (File)
Thu, Oct 10, 10:13 PM
Unknown Object (File)
Oct 2 2024, 9:17 AM
Unknown Object (File)
Sep 1 2024, 10:24 AM
Unknown Object (File)
Aug 26 2024, 2:56 PM
Subscribers

Details

Summary

Fixes T11575. Before, specials used to be separated by newlines, now they are returned as an array for us, or returned as a single value for us. Casting the result to an array is the minimum amount of disruption we can incur here to keep the existing logic in place and provide the same values.

Test Plan
  • deleted my src/.phutil_module_cache from arcanist, libphutil and phabricator
  • ran arc liberate src in all of those places
  • ran all of their unit tests
  • saw all tests pass and no modifications made to __phutil_library_map__.php for any of the libraries

Diff Detail

Repository
rPHU libphutil
Branch
symbol_loader_docblock (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13537
Build 17426: Run Core Tests
Build 17425: arc lint + arc unit