Page MenuHomePhabricator

Use new format for docblock specials when parsing symbols
ClosedPublic

Authored by yelirekim on Sep 2 2016, 4:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 8:16 PM
Unknown Object (File)
Jan 21 2024, 4:57 AM
Unknown Object (File)
Jan 7 2024, 2:09 PM
Unknown Object (File)
Jan 7 2024, 1:47 PM
Unknown Object (File)
Jan 7 2024, 1:47 PM
Unknown Object (File)
Jan 5 2024, 12:09 AM
Unknown Object (File)
Jan 3 2024, 11:30 PM
Unknown Object (File)
Jan 1 2024, 7:00 AM
Subscribers

Details

Summary

Fixes T11575. Before, specials used to be separated by newlines, now they are returned as an array for us, or returned as a single value for us. Casting the result to an array is the minimum amount of disruption we can incur here to keep the existing logic in place and provide the same values.

Test Plan
  • deleted my src/.phutil_module_cache from arcanist, libphutil and phabricator
  • ran arc liberate src in all of those places
  • ran all of their unit tests
  • saw all tests pass and no modifications made to __phutil_library_map__.php for any of the libraries

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable