Page MenuHomePhabricator
Differential D16470

Removed all instances of getIconURI
ClosedPublic
Actions

Authored by jcox on Aug 30 2016, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:33 AM
Unknown Object (File)
Mon, Apr 29, 2:06 PM
Unknown Object (File)
Wed, Apr 24, 10:10 PM
Unknown Object (File)
Sun, Apr 21, 4:34 PM
Unknown Object (File)
Sun, Apr 14, 12:38 AM
Unknown Object (File)
Apr 1 2024, 10:38 AM
Unknown Object (File)
Mar 4 2024, 7:52 PM
Unknown Object (File)
Feb 20 2024, 8:20 AM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11541: Remove getIconURI() from PhabricatorApplication
Commits
rPf2f896c761a2: Removed all instances of getIconURI
Summary

Fixes T11541. PhabricatorApplication::getIconURI() has been returning only null for a while (I assume in preparation to remove it). I removed the method and all the remaining call sites.

Test Plan

Removed the method and then clicked around. Things didn't explode!

Diff Detail

Repository
rP Phabricator
Branch
PurgeGetIconURI (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13500
Build 17366: Run Core Tests
Build 17365: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39625.Aug 30 2016, 2:00 PM
jcox retitled this revision from to Removed all instances of getIconURI.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T11541: Remove getIconURI() from PhabricatorApplication.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 30 2016, 2:00 PM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
epriestley accepted this revision.Aug 30 2016, 2:01 PM
epriestley added a reviewer: epriestley.

Nothing exploded? Hard to believe.

This revision is now accepted and ready to land.Aug 30 2016, 2:01 PM
jcox added inline comments.Aug 30 2016, 2:03 PM
src/applications/meta/typeahead/PhabricatorApplicationDatasource.php
39

wait a minute... are PHP function calls case-insensitive?

epriestley added a comment.Aug 30 2016, 2:04 PM

ohhyeah.jpg (294×281 px, 24 KB)

epriestley added a comment.Aug 30 2016, 2:05 PM

(Small comfort but variables aren't, at least.)

Closed by commit rPf2f896c761a2: Removed all instances of getIconURI (authored by jcox, committed by jcox). · Explain WhyAug 30 2016, 2:11 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11558: Update-after-commit possibly got mangled in diff-to-file change?.Aug 30 2016, 2:21 PM

Revision Contents
Changeset List

PathSize
src/
applications/
base/
4 lines
meta/
typeahead/
1 line
view/
11 lines

Diff 39625

View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php

Loading...
View Options

src/applications/meta/view/PhabricatorApplicationLaunchView.php

Loading...
Phabricator · Built by Phacility