Page MenuHomePhabricator
Differential D16420

Keep setIcon() working for now on PHUIObjectItemView
ClosedPublic
Actions

Authored by epriestley on Aug 19 2016, 11:55 AM.
Tags
None
Referenced Files
F13162169: D16420.diff
Mon, May 6, 12:29 PM
Unknown Object (File)
Fri, May 3, 2:31 AM
Unknown Object (File)
Mon, Apr 29, 5:16 PM
Unknown Object (File)
Mon, Apr 29, 2:03 PM
Unknown Object (File)
Wed, Apr 24, 10:08 PM
Unknown Object (File)
Sun, Apr 21, 4:17 PM
Unknown Object (File)
Sun, Apr 14, 11:40 PM
Unknown Object (File)
Thu, Apr 11, 7:28 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView
Commits
rP1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView
Summary

Ref T11501. This method was removed in D16418, but still has some callsites. I know of four:

  • Config
  • Settings
  • Drydock main page
  • Almanac main page

Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly.

Test Plan

Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing.

Diff Detail

Repository
rP Phabricator
Branch
icon1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/view/phui/PHUIObjectItemView.php:171XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 13362
Build 17146: Run Core Tests
Build 17145: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39487.Aug 19 2016, 11:55 AM
epriestley retitled this revision from to Keep setIcon() working for now on PHUIObjectItemView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.
epriestley mentioned this in T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.Aug 19 2016, 11:56 AM
chad accepted this revision.Aug 19 2016, 1:42 PM
chad edited edge metadata.

I'll fix tho proper when I get back from schools

This revision is now accepted and ready to land.Aug 19 2016, 1:42 PM
epriestley added a comment.Aug 19 2016, 2:25 PM

Closed by commit rP1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView (authored by epriestley, committed by epriestley). · Explain WhyAug 19 2016, 2:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
5 lines

Diff 39487

View Options

src/view/phui/PHUIObjectItemView.php

Loading...
Phabricator · Built by Phacility