Page MenuHomePhabricator

Make Herald test workflow modular and more clear
ClosedPublic

Authored by epriestley on Aug 2 2016, 3:31 PM.
Tags
None
Referenced Files
F12857948: D16360.id39350.diff
Fri, Mar 29, 11:06 AM
Unknown Object (File)
Wed, Mar 13, 1:41 PM
Unknown Object (File)
Sun, Mar 10, 1:56 AM
Unknown Object (File)
Jan 27 2024, 6:44 PM
Unknown Object (File)
Jan 23 2024, 8:07 PM
Unknown Object (File)
Dec 27 2023, 8:35 AM
Unknown Object (File)
Dec 27 2023, 8:35 AM
Unknown Object (File)
Dec 27 2023, 8:35 AM
Subscribers
None

Details

Summary

Fixes T9719. Currently, the Herald "Test Console" has a big instanceof thing, so new adapters (like a Calendar adapter, or third-party adapters) aren't available automatically. Instead, do a standard modular thing: load the available adapters, ask which ones can test the object the user selected, then let the user pick which one they want to move forward with.

Additionally, it isn't very clear that you can't test "commit hook" rules because they rely on push state which we don't really have a good way to simulate. When the user picks a commit, we now show them the "Hook" events, but the options are disabled and explain why they can not be selected.

Test Plan
  • Ran test rules for revisions, commits, mocks, tasks, wiki documents, questions, and outbound mail.
  • Plugged in a commit, got a more-helpful choice screen explaining why you do a test run of hook rules.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13229
Build 16952: Run Core Tests
Build 16951: arc lint + arc unit