Page MenuHomePhabricator
Differential D16332

Move command spelling correction to libphutil
ClosedPublic
Actions

Authored by epriestley on Jul 27 2016, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 1:43 AM
Unknown Object (File)
Tue, Dec 17, 12:59 AM
Unknown Object (File)
Tue, Dec 17, 12:43 AM
Unknown Object (File)
Sun, Dec 15, 3:20 AM
Unknown Object (File)
Wed, Dec 11, 4:40 PM
Unknown Object (File)
Sun, Dec 8, 11:43 PM
Unknown Object (File)
Sun, Dec 8, 11:43 PM
Unknown Object (File)
Sun, Dec 8, 11:43 PM
View All Files
Subscribers
joshuaspence

Details

Reviewers
chad
Maniphest Tasks
T7489: Move argument spelling correction to PhutilArgumentWorkflow
Commits
rPHUd4b891fbcd83: (stable) Promote 2016 Week 31
rPHUd0daa2b343e4: Move command spelling correction to libphutil
Summary

Ref T7489. Currently, arc has helpful flag/argument spelling correction but libphutil does not.

The implementation in arc is also pretty hard-coded, and exposed as static methods on ArcanistConfiguration. This class isn't closely related to argument parsing, and I would like to remove it anyway (see T10329).

This copies the bulk of the implementation to libphutil and separates it out so it isn't bolted onto some other class.

(arc may still need to do some of this on its own, since it has additional rules like aliases that I don't necessarily expect to generalize, but should be able to share this code.)

Test Plan
$ ./bin/repository reparce --messages
(Assuming "reparce" is the British spelling of "reparse".)
(Assuming "--messages" is the British spelling of "message".)
Usage Exception: Specify a commit or repository to reparse.
$ ./bin/repository heaw
Usage Exception: Invalid command "heaw". Did you mean:
      help
      thaw

For details on available commands, run `repository help`.

Diff Detail

Repository
rPHU libphutil
Branch
console1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13144
Build 16819: Run Core Tests
Build 16818: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39267.Jul 27 2016, 12:29 PM
epriestley retitled this revision from to Move command spelling correction to libphutil.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7489: Move argument spelling correction to PhutilArgumentWorkflow.
epriestley updated this revision to Diff 39268.Jul 27 2016, 12:35 PM
  • Slightly simpler code; let the corrector correct case changes ("DIFF" -> "diff") too.
epriestley updated this revision to Diff 39269.Jul 27 2016, 12:36 PM
  • Slightly more consistent "british" feedback for flags: "--x" is the spelling of "--y" (not "y", without "--").
epriestley mentioned this in D16333: Remove command spelling correction from Arcanist.Jul 27 2016, 12:41 PM
epriestley added a child revision: D16333: Remove command spelling correction from Arcanist.Jul 27 2016, 12:41 PM
chad accepted this revision.Jul 27 2016, 3:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:39 PM
Closed by commit rPHUd0daa2b343e4: Move command spelling correction to libphutil (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a subscriber: joshuaspence.Jul 27 2016, 11:46 PM

Was it intentional that this is no longer case-sensitive? I used this method for a custom linter rule and it no longer detects foobar as a mispelling of FOOBAR.

epriestley added a comment.Jul 28 2016, 12:47 AM

Sort of -- it intentionally normalizes everything to lowercase now (I think this would previously work, but not warn you about the correction):

$ ./bin/storage STATUS
(Assuming "STATUS" is the British spelling of "status".)
...

Revision Contents
Changeset List

Diff 39268

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/console/view/PhutilConsoleList.php

Loading...
View Options

src/parser/argument/PhutilArgumentParser.php

Loading...
View Options

src/parser/argument/PhutilArgumentSpellingCorrector.php

Loading...
View Options

src/parser/argument/__tests__/PhutilArgumentSpellingCorrectorTestCase.php

Loading...
Phabricator · Built by Phacility