Page MenuHomePhabricator

Re-implement calendar.invite transactions
ClosedPublic

Authored by avivey on Jul 17 2016, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 2:52 PM
Unknown Object (File)
Thu, Apr 11, 2:52 PM
Unknown Object (File)
Thu, Apr 11, 2:52 PM
Unknown Object (File)
Thu, Apr 11, 8:27 AM
Unknown Object (File)
Wed, Apr 10, 9:09 AM
Unknown Object (File)
Wed, Apr 10, 9:09 AM
Unknown Object (File)
Wed, Apr 10, 12:14 AM
Unknown Object (File)
Wed, Apr 3, 11:11 AM
Subscribers

Details

Summary

Fix T11339.
Now, old and new are both simple lists of phids, and the rendering should make sense.

Test Plan

Viewed existing transaction with all 3 states.

Diff Detail

Repository
rP Phabricator
Branch
calendarchange
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13108
Build 16760: Run Core Tests
Build 16759: arc lint + arc unit

Event Timeline

avivey retitled this revision from to render uninvites correctly.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
epriestley edited edge metadata.

Maybe a better solution will be to make both values plain lists of invitees

Yeah, I think I like this approach better, as it's more symmetrical if nothing else.

This revision now requires changes to proceed.Jul 18 2016, 6:40 PM
avivey edited edge metadata.
  • change implementation
avivey retitled this revision from render uninvites correctly to Re-implement calendar.invite transactions.Jul 21 2016, 12:44 AM
avivey updated this object.
avivey edited edge metadata.
epriestley edited edge metadata.
epriestley added inline comments.
resources/sql/autopatches/20160720.calendar.invitetxn.php
7

"Restructring" missing a "u" I think?

25–26

Prefer phutil_json_encode(), which throws if the value isn't encodable (e.g., invalid UTF8).

32–43

Consider inlining this code: these functions will exist at global scope for all time, and collide with other functions named update_old_value() and update_new_value() in the future. IDEs may identify these as functions for autocomplete when there is a ~0% chance any user ever intends to type them, etc.

This revision is now accepted and ready to land.Jul 21 2016, 11:13 AM
avivey updated this object.
avivey edited edge metadata.

inline things, phutil_json_encode

This revision was automatically updated to reflect the committed changes.