Fix T11339.
Now, old and new are both simple lists of phids, and the rendering should make sense.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T11339: Calendar: Inviting / uninviting transactions omit key information
- Commits
- rPb6bf0f6a3b49: Re-implement calendar.invite transactions
Viewed existing transaction with all 3 states.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 13105 Build 16755: Run Core Tests Build 16754: arc lint + arc unit
Event Timeline
Comment Actions
Maybe a better solution will be to make both values plain lists of invitees
Yeah, I think I like this approach better, as it's more symmetrical if nothing else.
| resources/sql/autopatches/20160720.calendar.invitetxn.php | ||
|---|---|---|
| 7 ↗ | (On Diff #39231) | "Restructring" missing a "u" I think? |
| 25–26 ↗ | (On Diff #39231) | Prefer phutil_json_encode(), which throws if the value isn't encodable (e.g., invalid UTF8). |
| 32–43 ↗ | (On Diff #39231) | Consider inlining this code: these functions will exist at global scope for all time, and collide with other functions named update_old_value() and update_new_value() in the future. IDEs may identify these as functions for autocomplete when there is a ~0% chance any user ever intends to type them, etc. |