Page MenuHomePhabricator
Differential D16252

add renderValue() in transactions
ClosedPublic
Actions

Authored by avivey on Jul 8 2016, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 10:59 AM
Unknown Object (File)
Mon, Jan 27, 9:11 AM
Unknown Object (File)
Sat, Jan 25, 6:52 PM
Unknown Object (File)
Fri, Jan 24, 2:38 PM
Unknown Object (File)
Fri, Jan 24, 2:38 PM
Unknown Object (File)
Fri, Jan 24, 2:37 PM
Unknown Object (File)
Fri, Jan 24, 2:37 PM
Unknown Object (File)
Fri, Jan 24, 2:37 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11290: bold text for values in transaction
Commits
rPf790dd5235b9: add renderValue() in transactions
Summary

fix T11290.

Test Plan

Paste language type, view in web and in emails (It uses quotes in HTML emails, which I think is something else).

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D16252
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12993
Build 16598: Run Core Tests
Build 16597: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 39092.Jul 8 2016, 12:12 AM
avivey retitled this revision from to add renderValue() in transactions.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: chad, epriestley.
avivey added a task: T11290: bold text for values in transaction.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2016, 12:12 AM
Herald added a subscriber: Korvin. · View Herald Transcript
avivey added a comment.Jul 8 2016, 12:12 AM

pasted_file (148×382 px, 19 KB)

epriestley edited edge metadata.Jul 8 2016, 12:15 AM

I'll let @chad pull the trigger on this one, but looks good to me.

The blinking may not be fast enough to sufficiently harm/annoy users.

avivey updated this revision to Diff 39119.Jul 8 2016, 11:22 PM
avivey edited edge metadata.

Remove blink

Herald edited edge metadata. · View Herald TranscriptJul 8 2016, 11:22 PM
chad edited edge metadata.Jul 8 2016, 11:46 PM

actually I'd probably italicize/darken it over bold. how does it look?

avivey added a comment.Jul 8 2016, 11:50 PM

bold:

pasted_file (154×297 px, 16 KB)

italic + black:

pasted_file (123×352 px, 17 KB)

italics:

pasted_file (119×393 px, 15 KB)

black:

pasted_file (165×384 px, 20 KB)

chad added a comment.Jul 8 2016, 11:51 PM

yeah, I did the dark italics better. thanks!

avivey added a comment.Jul 8 2016, 11:53 PM

what's the css for "dark"? I've used color: black.

chad added a comment.Jul 8 2016, 11:53 PM

{$darkbluetext} usually

chad added a comment.Jul 8 2016, 11:54 PM

black is fine too in this case

chad accepted this revision.Jul 8 2016, 11:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 11:54 PM
Closed by commit rPf790dd5235b9: add renderValue() in transactions (authored by avivey, committed by avivey). · Explain WhyJul 8 2016, 11:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
paste/
xaction/
12 lines
transactions/
storage/
14 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 39119

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility