Page MenuHomePhabricator
Files F15332855

D16252.diff
No OneTemporary
Actions

D16252.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '2fbe65a2',
+ 'core.pkg.css' => '4e7e9bde',
'core.pkg.js' => '1bcca0f3',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '3e81ae60',
@@ -155,7 +155,7 @@
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => 'd5263e49',
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
- 'rsrc/css/phui/phui-timeline-view.css' => 'c3782437',
+ 'rsrc/css/phui/phui-timeline-view.css' => 'bc523970',
'rsrc/css/phui/phui-two-column-view.css' => '9fb86c85',
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7',
'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647',
@@ -863,7 +863,7 @@
'phui-status-list-view-css' => 'd5263e49',
'phui-tag-view-css' => '6bbd83e2',
'phui-theme-css' => '027ba77e',
- 'phui-timeline-view-css' => 'c3782437',
+ 'phui-timeline-view-css' => 'bc523970',
'phui-two-column-view-css' => '9fb86c85',
'phui-workboard-color-css' => 'ac6fe6a7',
'phui-workboard-view-css' => 'e6d89647',
diff --git a/src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php b/src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php
--- a/src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php
+++ b/src/applications/paste/xaction/PhabricatorPasteLanguageTransaction.php
@@ -15,15 +15,19 @@
public function getTitle() {
return pht(
- "%s updated the paste's language.",
- $this->renderAuthor());
+ "%s updated the paste's language from %s to %s.",
+ $this->renderAuthor(),
+ $this->renderValue($this->getOldValue()),
+ $this->renderValue($this->getNewValue()));
}
public function getTitleForFeed() {
return pht(
- '%s updated the language for %s.',
+ '%s updated the language for %s from %s to %s.',
$this->renderAuthor(),
- $this->renderObject());
+ $this->renderObject(),
+ $this->renderValue($this->getOldValue()),
+ $this->renderValue($this->getNewValue()));
}
}
diff --git a/src/applications/transactions/storage/PhabricatorModularTransactionType.php b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
--- a/src/applications/transactions/storage/PhabricatorModularTransactionType.php
+++ b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
@@ -141,6 +141,20 @@
return $display;
}
+ final protected function renderValue($value) {
+ $rendering_target = $this->getStorage()->getRenderingTarget();
+ if ($rendering_target == PhabricatorApplicationTransaction::TARGET_TEXT) {
+ return sprintf('"%s"', $value);
+ }
+
+ return phutil_tag(
+ 'span',
+ array(
+ 'class' => 'phui-timeline-value',
+ ),
+ $value);
+ }
+
final protected function newError($title, $message, $xaction = null) {
return new PhabricatorApplicationTransactionValidationError(
$this->getTransactionTypeConstant(),
diff --git a/webroot/rsrc/css/phui/phui-timeline-view.css b/webroot/rsrc/css/phui/phui-timeline-view.css
--- a/webroot/rsrc/css/phui/phui-timeline-view.css
+++ b/webroot/rsrc/css/phui/phui-timeline-view.css
@@ -256,6 +256,11 @@
color: {$lightgreytext};
}
+.phui-timeline-title .phui-timeline-value {
+ font-style: italic;
+ color: black;
+}
+
.device-desktop .phui-timeline-extra {
float: right;
}

File Metadata

Mime Type
text/plain
Expires
Mar 8 2025, 9:08 PM (6 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7229860
Default Alt Text
D16252.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility