Page MenuHomePhabricator

horribly fix plain-text email for modular transactions
ClosedPublic

Authored by avivey on Jul 8 2016, 12:03 AM.
Tags
None
Referenced Files
F12838268: D16251.id39091.diff
Thu, Mar 28, 6:02 PM
F12838233: D16251.id39094.diff
Thu, Mar 28, 6:01 PM
F12837761: D16251.id.diff
Thu, Mar 28, 5:27 PM
F12837357: D16251.id.diff
Thu, Mar 28, 4:54 PM
Unknown Object (File)
Wed, Mar 27, 5:12 PM
Unknown Object (File)
Mon, Mar 25, 6:35 PM
Unknown Object (File)
Mon, Mar 25, 5:30 PM
Unknown Object (File)
Wed, Mar 20, 5:59 AM
Subscribers
Tokens
"Y So Serious" token, awarded by chad."Orange Medal" token, awarded by yelirekim.

Details

Summary

This is the quickest and dirtiest fix I could come up with.

PhabricatorApplicationTransaction::getTitleForMail() is using clone $this, which doesn't actually effect implementation.
Ref T9789.

Test Plan

update paste comment, get plaintext mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to horribly fix plain-text email for modular transactions.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey edited edge metadata.
epriestley added a reviewer: epriestley.

(The clone might be in case the method throws? Doesn't seem like a big deal either way.)

This revision is now accepted and ready to land.Jul 8 2016, 12:06 AM
This revision was automatically updated to reflect the committed changes.