Page MenuHomePhabricator
Differential D16251

horribly fix plain-text email for modular transactions
ClosedPublic
Actions

Authored by avivey on Jul 8 2016, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 6:47 AM
Unknown Object (File)
Thu, Apr 11, 8:06 AM
Unknown Object (File)
Wed, Apr 3, 9:50 AM
Unknown Object (File)
Wed, Apr 3, 7:08 AM
Unknown Object (File)
Wed, Apr 3, 7:08 AM
Unknown Object (File)
Fri, Mar 29, 3:26 PM
Unknown Object (File)
Thu, Mar 28, 6:02 PM
Unknown Object (File)
Thu, Mar 28, 6:01 PM
View All Files
Subscribers
epriestley
Tokens
"Y So Serious" token, awarded by chad."Orange Medal" token, awarded by yelirekim.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9789: Make it easier to write custom transaction types
Commits
rPb656c87e3756: horribly fix plain-text email for modular transactions
Summary

This is the quickest and dirtiest fix I could come up with.

PhabricatorApplicationTransaction::getTitleForMail() is using clone $this, which doesn't actually effect implementation.
Ref T9789.

Test Plan

update paste comment, get plaintext mail.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12967
Build 16557: Run Core Tests
Build 16556: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 39091.Jul 8 2016, 12:03 AM
avivey retitled this revision from to horribly fix plain-text email for modular transactions.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a task: T9789: Make it easier to write custom transaction types.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2016, 12:03 AM
Herald added a subscriber: epriestley. · View Herald Transcript
avivey updated this object.Jul 8 2016, 12:03 AM
avivey edited edge metadata.
yelirekim awarded a token.Jul 8 2016, 12:05 AM
epriestley accepted this revision.Jul 8 2016, 12:06 AM
epriestley added a reviewer: epriestley.

(The clone might be in case the method throws? Doesn't seem like a big deal either way.)

This revision is now accepted and ready to land.Jul 8 2016, 12:06 AM
Closed by commit rPb656c87e3756: horribly fix plain-text email for modular transactions (authored by avivey, committed by avivey). · Explain WhyJul 8 2016, 12:17 AM
This revision was automatically updated to reflect the committed changes.
chad awarded a token.Jul 8 2016, 12:38 AM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
9 lines

Diff 39091

View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
Phabricator · Built by Phacility