Page MenuHomePhabricator

Give prose diffs some basic test coverage
ClosedPublic

Authored by epriestley on Jun 7 2016, 3:06 PM.
Tags
None
Referenced Files
F19915272: D16067.diff
Fri, Apr 3, 5:49 PM
F19900948: D16067.diff
Mon, Mar 30, 6:53 AM
F19555432: D16067.id38659.diff
Jan 30 2026, 3:06 PM
F19512229: D16067.id.diff
Jan 12 2026, 2:39 PM
F19305033: D16067.id.diff
Dec 24 2025, 4:22 PM
F19289265: D16067.diff
Dec 23 2025, 8:13 AM
F19228969: D16067.diff
Dec 20 2025, 11:43 AM
F19020046: D16067.diff
Nov 23 2025, 4:53 PM
Subscribers
None

Details

Summary

Ref T7643. This strategy looks like it's a reasonable way to get these diffs to "pretty good, most of the time" levels. Since I'm not plannign to throw it away, start adding some test coverage.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give prose diffs some basic test coverage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.