Page MenuHomePhabricator
Differential D16040

Convert user profile images into a standard cache
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 1:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:38 AM
Unknown Object (File)
Wed, Apr 24, 11:20 PM
Unknown Object (File)
Fri, Apr 19, 4:49 PM
Unknown Object (File)
Thu, Apr 11, 12:40 PM
Unknown Object (File)
Thu, Apr 11, 9:25 AM
Unknown Object (File)
Tue, Apr 2, 9:00 PM
Unknown Object (File)
Mar 30 2024, 2:14 AM
Unknown Object (File)
Mar 26 2024, 4:04 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T10078: Implement global readthrough cache pools
Commits
rP6f1053c206f1: Convert user profile images into a standard cache
Summary

Ref T4103. Ref T10078. This moves profile image caches to new usercache infrastructure.

These dirty automatically based on configuration and User properties, so add some stuff to make that happen.

This reduces the number of queries issued on every page by 1.

Test Plan

Browsed around, changed profile image, viewed as self, viewed as another user, verified no more query to pull this information on every page

Diff Detail

Repository
rP Phabricator
Branch
setting30
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12466
Build 15798: Run Core Tests
Build 15797: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38591.Jun 5 2016, 1:00 AM
epriestley retitled this revision from to Convert user profile images into a standard cache.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10078: Implement global readthrough cache pools, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad edited edge metadata.Jun 5 2016, 2:08 AM

Unit test failures?

epriestley added a comment.Jun 5 2016, 3:58 AM

Those failures are probably fixed in D16041, let me backport the fixes.

epriestley planned changes to this revision.Jun 5 2016, 4:04 AM

Oh, no, they're not directly related. Some unit tests try to build/access users in weird ways that don't work with some of the cache stuff. I'll sort it out in the morning.

epriestley mentioned this in D16042: Make caches misses throw by default intead of inline-generating.Jun 5 2016, 1:39 PM
epriestley updated this revision to Diff 38595.Jun 5 2016, 1:42 PM
epriestley edited edge metadata.
  • Rebase on D16042, which fixes unit tests.
chad accepted this revision.Jun 5 2016, 2:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2016, 2:53 PM
Closed by commit rP6f1053c206f1: Convert user profile images into a standard cache (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:52 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP2b344b2bb500: Make caches misses throw by default intead of inline-generating.

Revision Contents
Changeset List

Diff 38595

View Options

resources/sql/autopatches/20160604.user.02.removeimagecache.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserCacheType.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserProfileImageCacheType.php

Loading...
View Options

src/applications/people/extension/PhabricatorPeopleMainMenuBarExtension.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserCache.php

Loading...
Phabricator · Built by Phacility